Integrate 10/10 #13996
Integrate 10/10 #13996
Conversation
|
The 'E2E Test App Fabric' test seems to be failing on two of the tests on the Pressable component - both involving a Text component (link to CI): I looked at the components that are failing in RNTester on both main and this integration branch and there was no visual difference in the behaviour - not sure why they are unable to be found when running the test command. Edit: this issue has been resolved - the default accessible value for text got changed in the merge process. |
| context, | ||
| rawProps, | ||
| "endDraggingSensitivityMultiplier", | ||
| sourceProps.endDraggingSensitivityMultiplier, |
There was a problem hiding this comment.
Do we still need this file or can we delete it?
There was a problem hiding this comment.
I also see that NativeAnimatedHelper.win32.js is still in the repo, I'm not sure #11041 is actually resolved
There was a problem hiding this comment.
Removed #11041 from resolved issues. Deleted the unused fork.
| accessible == null | ||
| ? onPress != null || onLongPress != null | ||
| : accessible, | ||
| default: accessible !== false, |
There was a problem hiding this comment.
just curious, is this specific for windows? If so, we should add a comment so it doesn't get removed in future integrations
There was a problem hiding this comment.
Yes - added a comment for future reference.
| accessible == null | ||
| ? onPress != null || onLongPress != null | ||
| : accessible, | ||
| default: accessible !== false, |
2 participants
Description
Integration
Commit Range: facebook/react-native@223e98c...0d6908f
Notable Commits
NativeAnimatedModuleMock for Jest facebook/react-native#46715HostInstanceType facebook/react-native#46742React.AbstractComponenttype to usecomponent typefacebook/react-native#46855componenttype in Text facebook/react-native#46912Issues Resolved
New follow-up issues
AccessibilityInfo::isHighTextContrastEnabled()inAccessibilityInfoModule#14099Changelog
Should this change be included in the release notes: no
Add a brief summary of the change to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow