-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hot reloading dependencies #6325
Conversation
By analyzing the blame information on this pull request, we identified @skevy, @cpojer and @davidaurelio to be potential reviewers. |
Awesome, thanks @gaearon! |
@facebook-github-bot import |
Thanks @gaearon :) |
Do I need to do anything here? |
@gaearon nope. You shouldn't. Martin imported the change so that he can merge it manually. We do this with dependency changes so the shrinkwrap can be updated appropriately. |
We should have the bot reply after import. cc @bestander @mkonicek |
👍 Thanks. |
Let me try again |
@facebook-github-bot import |
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ok, so it was imported but Bot did not comment. |
I've been trying to land this yesterday all day long but we've had some internal flakiness... |
2e9c888
Summary:These updates include important changes to correctness in the linked and underlying packages: * https://github.com/gaearon/babel-plugin-react-transform/releases/tag/v2.0.1 * https://github.com/gaearon/babel-plugin-react-transform/releases/tag/v2.0.2 * https://github.com/gaearon/react-proxy/releases/tag/v1.1.3 * https://github.com/gaearon/react-proxy/releases/tag/v1.1.4 * etc We need to include these if we want to ship hot reloading. Create a new project with those versions of packages. <img width="761" alt="screen shot 2016-03-06 at 18 49 20" src="https://cloud.githubusercontent.com/assets/810438/13556222/2d45ca62-e3cc-11e5-8a3f-a2346efe19dd.png"> Verify hot reloading still works. ![](http://cl.ly/2J150y0Y3E1z/download/Screen%20Recording%202016-03-06%20at%2018.48.gif) martinbigio skevy I wasn’t sure whether to touch the shrinkwrap. Closes #6325 Reviewed By: yungsters Differential Revision: D3019470 Pulled By: martinbigio fb-gh-sync-id: 99bad390cd898f58aa7f74494066561a81eb40e6 shipit-source-id: 99bad390cd898f58aa7f74494066561a81eb40e6
Motivation
These updates include important changes to correctness in the linked and underlying packages:
We need to include these if we want to ship hot reloading.
Test Plan
Create a new project with those versions of packages.
Verify hot reloading still works.
Reviewers
@martinbigio @skevy
Notes
I wasn’t sure whether to touch the shrinkwrap.