Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hot reloading dependencies #6325

Closed
wants to merge 1 commit into from
Closed

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 6, 2016

Motivation

These updates include important changes to correctness in the linked and underlying packages:

We need to include these if we want to ship hot reloading.

Test Plan

Create a new project with those versions of packages.

screen shot 2016-03-06 at 18 49 20

Verify hot reloading still works.

Reviewers

@martinbigio @skevy

Notes

I wasn’t sure whether to touch the shrinkwrap.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @skevy, @cpojer and @davidaurelio to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 6, 2016
@martinbigio
Copy link
Contributor

Awesome, thanks @gaearon!

@martinbigio
Copy link
Contributor

@facebook-github-bot import

@skevy
Copy link
Contributor

skevy commented Mar 7, 2016

Thanks @gaearon :)

@gaearon
Copy link
Collaborator Author

gaearon commented Mar 7, 2016

Do I need to do anything here?

@skevy
Copy link
Contributor

skevy commented Mar 7, 2016

@gaearon nope. You shouldn't. Martin imported the change so that he can merge it manually. We do this with dependency changes so the shrinkwrap can be updated appropriately.

@satya164
Copy link
Contributor

satya164 commented Mar 7, 2016

We should have the bot reply after import. cc @bestander @mkonicek

@gaearon
Copy link
Collaborator Author

gaearon commented Mar 7, 2016

👍 Thanks.

@bestander
Copy link
Contributor

Let me try again

@bestander
Copy link
Contributor

@facebook-github-bot import

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@bestander
Copy link
Contributor

ok, so it was imported but Bot did not comment.
@martinbigio is comandeering it already

@martinbigio
Copy link
Contributor

I've been trying to land this yesterday all day long but we've had some internal flakiness...

@martinbigio martinbigio mentioned this pull request Mar 8, 2016
7 tasks
@ghost ghost closed this in 2e9c888 Mar 12, 2016
bestander pushed a commit that referenced this pull request Mar 15, 2016
Summary:These updates include important changes to correctness in the linked and underlying packages:

* https://github.com/gaearon/babel-plugin-react-transform/releases/tag/v2.0.1
* https://github.com/gaearon/babel-plugin-react-transform/releases/tag/v2.0.2
* https://github.com/gaearon/react-proxy/releases/tag/v1.1.3
* https://github.com/gaearon/react-proxy/releases/tag/v1.1.4
* etc

We need to include these if we want to ship hot reloading.

Create a new project with those versions of packages.

<img width="761" alt="screen shot 2016-03-06 at 18 49 20" src="https://cloud.githubusercontent.com/assets/810438/13556222/2d45ca62-e3cc-11e5-8a3f-a2346efe19dd.png">

Verify hot reloading still works.

![](http://cl.ly/2J150y0Y3E1z/download/Screen%20Recording%202016-03-06%20at%2018.48.gif)

martinbigio skevy

I wasn’t sure whether to touch the shrinkwrap.
Closes #6325

Reviewed By: yungsters

Differential Revision: D3019470

Pulled By: martinbigio

fb-gh-sync-id: 99bad390cd898f58aa7f74494066561a81eb40e6
shipit-source-id: 99bad390cd898f58aa7f74494066561a81eb40e6
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants