Issue to track 0.22 stability

[bestander]

List of commits to cherry-pick into 0.22-stable branch

• node-haste fix Windows compat fd816b1
• live reload 2e9c888 972395a
• netinfo fetch 336dbe4
• new npm publish script with CI ceb6bd5
• fix HMR variable namings d0caf7e - not importing this
• source maps fix bcb37c0
• revert f538032

[satya164]

For HMR, we need to do disable the HMR menu on Android when Dev is disabled. I'll do it. Just mentioning here.

[janicduplessis]

#6260 When the node-haste stuff is resolved.

---

added

[martinbigio]

#6325 when it lands in a few minutes

---

added

[corbt]

#6373 fixes NetInfo.fetch returning undefined.

---

addded

[satya164]

#6325 landed in 2e9c888

---

added

[martinbigio]

@davidaurelio if we cherry pick #6260 wouldn't we need to pick 972395a as well so that HMR doesn't break?

cc @bestander

---

added

[martinbigio]

Lets cherry pick 972395a as well

---

same as above, added

[corbt]

#6373 landed in 336dbe4

---

added

[bestander]

releasing 0.22.0-rc1 automatically with CI for the first time
The first 4 ticks were cherry-picked

[rclai]

Are you guys able to add in this one?

[bestander]

it should be in RC already

On Tue, Mar 15, 2016 at 6:06 PM, Richard Lai notifications@github.com
wrote:

Are you guys able to add in this one
0176ac4
?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6366 (comment)

[janicduplessis]

Will 0.22.0-rc1 be on npm? If it is I can tell users that had issues on windows to update to that.

[pthrasher]

Will this also contain all the various changes for relay compatibility?

[bestander]

yes, once this is green
https://circleci.com/gh/facebook/react-native/tree/0.22-stable
You can do npm install react-native@0.22.0-rc1

On Tue, Mar 15, 2016 at 6:31 PM, Janic Duplessis notifications@github.com
wrote:

Will 0.22.0-rc1 be on npm? If it is I can tell users that had issues on
windows to update to that.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6366 (comment)

[bestander]

FYI react-native@0.22.0-rc4 has been published to npm.
It includes cherry-picked commits from the list above.
If no more things to be picked till Monday we will release it as react-native@0.22.0

[bestander]

@pthrasher react-native@0.22.0-rc4 has react as peer dependency installed at the root of node_modules. This should allow Relay compatibility afaik.

[pthrasher]

@bestander thanks! :-)

[martinbigio]

need to cherry pick this one as well: d0caf7e

---

After talking to Martin decided not to cherry pick considering that it requires a few commits to be picked

[cknitt]

Are you aware that rc4 seems to include different versions of css-layout for iOS and Android?

See #6447 and @vjeux's comments in #6237 and f538032.

It seems the fix from facebook/yoga#145 was merged for Android, but not for iOS. It would be great if you could get it merged for iOS, too, before releasing 0.22.0.

---

For IOS this commit was done 6c5195f
But it was reverted in c1762c7
The issue related to this is opened here: facebook/yoga#175

We don't have a quick fix in the master branch for that.
To make the both platforms consistent I'll revert the fix for Android only for 0.22 branch.
In the next week or so @javache will work on having a consistent fix for both platforms.

[daesan]

When I run 0.22.0-rc4, my app hangs at the following code.

NSArray<NSHTTPCookie *> *cookies = [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:components.URL];
Libraries/WebSocket/RCTSRWebSocket.m line 290

I think this happens when my app tries to fetch remote javascript code. Are anyone else having this issue? Could someone guess what might be the problem?

[bestander]

A wild guess - JavaScript did not compile and server can't start.
Can you do 'npm start' in terminal?

[daesan]

Sure. I tried running the app several times and sometimes the server is accessed and other times the server is not even accessed.

I mean I see the following output on the console, only some of the times when I run the app.

[10:58:15 AM] <START> request:/index.ios.bundle?platform=ios&dev=false
[10:58:15 AM] <END> request:/index.ios.bundle?platform=ios&dev=false (34ms)

Also the following is the error I see on XCode.

---

added comment below

[martinbigio]

@bestander need to cherry pick this one as well: bcb37c0

---

added to the list

[bestander]

Thanks for more details, @daesan.
This issue is created for tracking what needs to be cherry-picked into the release, i.e. things that are already in master branch.
In your case better create a standalone issue and help us track it and land a fix into master branch. Only then we could cherry-pick it into release.
BTW, there are quite a few issues with this error https://github.com/facebook/react-native/search?q=EXC_BAD_ACCESS&type=Issues&utf8=%E2%9C%93, are they related to your problem?
0.22 is due to release today, most likely your issue won't be fixed by then, let's try to get it fixed in the next RC coming this week

[bestander]

0.22.0-rc5 is being released to npm.
Cherry-picking d0caf7e is a bit involved, delaying 0.22.0 release while resolving it

[bestander]

0.22.0 is released.

[daesan]

@bestander Got you. I thought this could be a release holding issue but it turns out that this only arises when JSX bundle is hosted on Linux server.

I created a new issue as you suggested. #6581 If someone has a clue about this error please talk about it there.