getCurrentConnectivity should resolve with object

[mrlaessig]

getCurrentConnectivity() should resolve with object instead of array otherwise in NetInfo.fetch().done(reach => console.log('Initial: ' + reach)) reach will be undefined (see https://github.com/l-urence/react-native/blob/master/Libraries/Network/NetInfo.js#L200).

cc @satya164

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @satya164, @nicklockwood and @vjeux to be potential reviewers.

[mrlaessig]

As far as I can see Android looks good. But never tested.

[corbt]

I've also noticed that NetInfo.fetch appears broken currently, and it looks like this should fix it. Do you have a test plan? Perhaps a code sample that shows how it was broken before and now works? Thanks for this!

[satya164]

cc @bestander @nicklockwood

[corbt]

I think NetInfo.fetch was just forgotten in c9a1956. Probably would be worth looking for calls to RCTPromiseResolveBlock and making sure nothing else was missed.

[satya164]

ccing @dmmiller too

[mrlaessig]

Apparently all other RCTPromiseResolveBlock calls are okay or at least they do not return an array (find . -name *.m | xargs egrep 'resolve\(').

@corbt The code should now work as described in the documentation.

[corbt]

sweet, thanks again for working on this @l-urence.

@facebook-github-bot shipit

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to Phabricator to review.

[dmmiller]

Thanks for catching this one.

[shraddha1704]

I upgraded to 0.22 today. I am getting the following error:
undefined is not an object (evaluating 'RCTNetInfo.getCurrentConnectivity().then')

[bestander]

@shraddha1704 this PR was picked into 0.22 release.
Try creating a new issue with more details please

[shraddha1704]

Found a solution. Replacing the fetch function in NetInfo.js with:
fetch(): Promise {
return new Promise((resolve, reject) => {
RCTNetInfo.getCurrentConnectivity(
function(resp) {
resolve(resp.network_info);
},
reject
);
});
},

[satya164]

@shraddha1704 Your native code seems to be out of date. Run react-native upgrade to update your native files.