Add noop useDebugValue hook to partial/server renderer (#14597)

facebook · Jan 15, 2019 · 153a0b5 · 153a0b5
1 parent 0ca628b
commit 153a0b5
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactDOMServerIntegrationHooks-test.internal.js b/packages/react-dom/src/__tests__/ReactDOMServerIntegrationHooks-test.internal.js
@@ -26,6 +26,7 @@ let useMemo;
 let useRef;
 let useImperativeHandle;
 let useLayoutEffect;
+let useDebugValue;
 let forwardRef;
 let yieldedValues;
 let yieldValue;
@@ -48,6 +49,7 @@ function initModules() {
  useCallback = React.useCallback;
  useMemo = React.useMemo;
  useRef = React.useRef;
+ useDebugValue = React.useDebugValue;
  useImperativeHandle = React.useImperativeHandle;
  useLayoutEffect = React.useLayoutEffect;
  forwardRef = React.forwardRef;
@@ -658,4 +660,16 @@ describe('ReactDOMServerHooks', () => {
  'Hooks can only be called inside the body of a function component.',
  );
  });
+
+ describe('useDebugValue', () => {
+ itRenders('is a noop', async render => {
+ function Counter(props) {
+ const debugValue = useDebugValue(123);
+ return <Text text={typeof debugValue} />;
+ }
+
+ const domNode = await render(<Counter />);
+ expect(domNode.textContent).toEqual('undefined');
+ });
+ });
 });
diff --git a/packages/react-dom/src/server/ReactPartialRendererHooks.js b/packages/react-dom/src/server/ReactPartialRendererHooks.js
@@ -351,6 +351,8 @@ export const Dispatcher = {
  useImperativeHandle: noop,
  // Effects are not run in the server environment.
  useEffect: noop,
+ // Debugging effect
+ useDebugValue: noop,
 };
 export const DispatcherWithoutHooks = {
  readContext,