Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noop useDebugValue hook to partial/server renderer #14597

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 15, 2019

No description provided.

@gaearon
Copy link
Collaborator

gaearon commented Jan 15, 2019

Shall we add some Flow typing to ensure their set of methods doesn't diverge again?

@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 15, 2019

Merging this for now. Will look at adding a Flow check to prevent divergence in a follow up

Edit: Follow up PR #14599

@bvaughn bvaughn merged commit 153a0b5 into facebook:master Jan 15, 2019
@bvaughn bvaughn deleted the useDebugValue-server-side branch January 15, 2019 19:00
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants