Skip to content

Commit

Permalink
Update on "compiler: Add support for ref effects"
Browse files Browse the repository at this point in the history
Fixes false positives where we currently disallow mutations of refs from callbacks passed to JSX, if the ref is also passed to jsx. We consider these to be mutations of "frozen" values, but refs are explicitly allowed to have interior mutability. The fix is to always allow (at leat within InferReferenceEffects) for refs to be mutated. This means we completely rely on ValidateNoRefAccessInRender to validate ref access and stop reporting false positives.

[ghstack-poisoned]
  • Loading branch information
josephsavona committed Jun 7, 2024
2 parents 6e5b2bc + 3f9d062 commit 2cfa72f
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 2cfa72f

Please sign in to comment.