no more vars (convert var to let/const) #11699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphamorim
changed the title
raphamorim
force-pushed
the
feature/no-more-vars
branch
from
37ef5ca to
513e921
Compare
gaearon
reviewed
Nov 29, 2017
packages/react-art/npm/Circle.js
Outdated
| var PropTypes = require('prop-types'); | ||
| var React = require('react'); | ||
| var ReactART = require('react-art'); | ||
| const assign = require('object-assign'); |
There was a problem hiding this comment.
We can't do this. This file ships on npm without transpilation. So it needs to be ES5. Same for all other files in /npm/ folder.
There was a problem hiding this comment.
Ok, I'll change it.
There was a problem hiding this comment.
changed in 4446de5
gaearon
requested changes
Nov 29, 2017
|
Ok, leave it to me @gaearon |
raphamorim
force-pushed
the
feature/no-more-vars
branch
from
513e921 to
4446de5
Compare
raphamorim
force-pushed
the
feature/no-more-vars
branch
from
4446de5 to
e5d4762
Compare
|
@gaearon I was wondering if I could send the remaining files in a separated PR. |
|
This is really hard to review too. |
|
Sure :) |
This was referenced Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discuss with @gaearon in #11637. I guess it's best to continue with #6097.
I took the liberty of following the footsteps of #6097 and sending this PR.
But still missing run it on files with Flow.