Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-art: Update Rectangle #13952

Closed
wants to merge 1 commit into from
Closed

react-art: Update Rectangle #13952

wants to merge 1 commit into from

Conversation

marcelometal
Copy link
Contributor

Replaced 'var' with 'const'

@marcelometal
react-art: Update Rectangle
8310480 
Replaced 'var' with 'const'
@sizebot
Copy link

sizebot commented Oct 24, 2018

Details of bundled changes.

Comparing: b5539ad...8310480

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@klamping klamping mentioned this pull request Oct 24, 2018
Open
@aweary
Copy link
Contributor

aweary commented Oct 24, 2018

Thanks, but we typically don't take minor changes like this that doesn't fix any known bugs.

@aweary aweary closed this Oct 24, 2018
@marcelometal
Copy link
Contributor Author

@aweary Really?

#11720
#11776
#11780
#11766
#11730
#11731
...
etc

there are a lot of MRs =/

@aweary
Copy link
Contributor

aweary commented Oct 25, 2018

Sorry, I didn't know there was a larger effort for this. Either way, we can't make this change. Anything in npm is published untranspiled. See #11699 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcelometal @sizebot @aweary @facebook-github-bot