Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fixing flaky async tests referenced in #13907 #13911

Closed
wants to merge 1 commit into from

Conversation

evmiguel
Copy link

This is a work in progress PR. Not ready for review.

Fixes #13907

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test). Tip: yarn test --watch TestName is helpful in development.
  5. Run yarn test-prod to test in the production environment. It supports the same options as yarn test.
  6. If you need a debugger, run yarn debug-test --watch TestName, open chrome://inspect, and press "Inspect".
  7. Format your code with prettier (yarn prettier).
  8. Make sure your code lints (yarn lint). Tip: yarn linc to only check changed files.
  9. Run the Flow typechecks (yarn flow).
  10. If you haven't already, complete the CLA.

Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html

@sizebot
Copy link

sizebot commented Oct 20, 2018

Details of bundled changes.

Comparing: 8ecd4bd...a92d245

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@gaearon
Copy link
Collaborator

gaearon commented Oct 20, 2018

Thanks for looking into this! We landed a fix in b753f76, but appreciate the initial investigation.

@gaearon gaearon closed this Oct 20, 2018
@acdlite
Copy link
Collaborator

acdlite commented Oct 21, 2018

@evmiguel I'm so sorry that I didn't see this! I had started my branch last night before I went to bed and forgot to check the PRs before I landed it. Otherwise I would have based my work on yours and given you credit. Really appreciate the PR :)

@blling

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests on node version 10
6 participants