Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not export passiveBrowserEventsSupported from Focus module #18022

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Feb 11, 2020

We should not be exporting passiveBrowserEventsSupported from this module.

@trueadm trueadm requested a review from bvaughn February 11, 2020 23:44
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 11, 2020
@threepointone
Copy link
Contributor

Why re-include the legacy builds if you’re removing the problematic export?

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Preemptive stamp)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7ccf096:

Sandbox Source
heuristic-montalcini-gf7m7 Configuration

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f739236:

Sandbox Source
relaxed-gauss-0n1yv Configuration

@sizebot
Copy link

sizebot commented Feb 11, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against f739236

@sizebot
Copy link

sizebot commented Feb 11, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against f739236

@bvaughn bvaughn merged commit 988f4b1 into facebook:master Feb 11, 2020
@trueadm trueadm deleted the focus-repsponder-no-export branch February 11, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants