Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove legacy www config from Rollup build" #18024

Closed
wants to merge 1 commit into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 12, 2020

Reverts #18016

I think we still need to do this. #18022 just solved one specific case, and we happen to not have more cases at the moment. But if making a change to the code can cause this problem to reappear, the problem is not solved.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0f60e6:

Sandbox Source
stoic-mclaren-qwni5 Configuration

@gaearon
Copy link
Collaborator Author

gaearon commented Feb 13, 2020

Let's just fix this: D19880784.

@gaearon
Copy link
Collaborator Author

gaearon commented Feb 17, 2020

I solved this in WWW instead.

@gaearon gaearon closed this Feb 17, 2020
@kassens kassens deleted the revert-18016-build-legacy-config branch November 29, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants