Flare: Fix listener upgrade bug #18270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit db1f226:
|
Details of bundled changes.Comparing: 2953425...db1f226 react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
Details of bundled changes.Comparing: 2953425...db1f226 react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
threepointone
approved these changes
Mar 10, 2020
Flare: fix bug with event upgrading Fix Fix
trueadm
force-pushed
the
fix-listener-upgrade
branch
from
51fcc95 to
db1f226
Compare
necolas
approved these changes
Mar 10, 2020
sebmarkbage
reviewed
Mar 18, 2020
| topLevelType: string, | ||
| listener: any => void, | ||
| ) { | ||
| if (listener.remove != null) { |
There was a problem hiding this comment.
This is not great because we're shipping this code even if it's not an FB listener. Like if Function.prototype.remove is added on the page. It also confuses the compiler. We should be sure which path we're using and consistently call that - statically
| passive: true, | ||
| }); | ||
| } else { | ||
| document.removeEventListener(topLevelType, listener, true); |
There was a problem hiding this comment.
This isn't going through the forked indirection which isn't the right layering. This whole function should all be moved to EventListener.js. That way it can be properly forked and you can statically choose which function to call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that was found internally when attempting to upgrade to an active event listener. We weren't properly removing the passive event listener. Also wired up logic for fb event listeners so we correctly remove those too.