Don't use EventListener Fork in Modern WWW Builds #18333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way we can statically compile out more of these indirections.
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
Mar 18, 2020
| if (passiveBrowserEventsSupported) { | ||
| targetContainer.removeEventListener(rawEventName, listener, { | ||
| capture, | ||
| passive, |
There was a problem hiding this comment.
The passive flag is not needed when removing. Only the capture flag needs to be specified.
sebmarkbage
commented
Mar 18, 2020
| validTargetContainer.removeEventListener( | ||
| ((rawEventName: any): string), | ||
| (listener: any), | ||
| ); |
There was a problem hiding this comment.
This wasn't specifying the capture flag but I fixed that.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fdf0b23:
|
Details of bundled changes.Comparing: aae83a4...fdf0b23 react-dom
Size changes (experimental) |
Details of bundled changes.Comparing: aae83a4...fdf0b23 react-dom
Size changes (stable) |
trueadm
approved these changes
Mar 18, 2020
| @@ -259,20 +250,9 @@ export function removeTrappedEventListener( | |||
| capture: boolean, | |||
| listener: any => void, | |||
| passive: void | boolean, | |||
There was a problem hiding this comment.
This argument is not used anymore, I'll address in #18336.
|
I'm merging this as it feeds into #18336. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If D20382065 successfully rolls out (has some issues still). Then we don't need this fork anymore.
We should start by at least removing it from Modern builds.
To do this I needed to fix the unsubscribing stuff mentioned in #18270 (comment). Flare is now used by both the FB fork and without it so we should just compile to one or the other. I do that by always returning an unsubscribe listener and always passing that to a removeEventListener function. The indirections can then be compiled out.