Modern Event System: refactor legacy FB support logic #18336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
Details of bundled changes.Comparing: 1cf4a17...7cc9fca react-dom
Size changes (experimental) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7cc9fca:
|
trueadm
force-pushed
the
fix-fb-listener
branch
2 times, most recently
from
0f5e333 to
66f7c8d
Compare
threepointone
approved these changes
Mar 19, 2020
trueadm
force-pushed
the
fix-fb-listener
branch
from
ea3ae21 to
7cc9fca
Compare
sthagen
added a commit
to sthagen/facebook-react
that referenced
this pull request
Mar 19, 2020
Modern Event System: refactor legacy FB support logic (facebook#18336)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big refactor of the FB event support logic in the modern event system. Previously, the logic worked for only Primer, but on more internal cases occuring, it seems we should probably delegated all "click" events to after the internal tooling runs, which fixes all the known issues with the legacy FB event systems. To ensure this works better, I've also made all the modern event system tests run with and without the internal FB flag so we catch more cases with this change.