Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect unmounted state update warning #18617

Merged
merged 3 commits into from
Apr 18, 2020
Merged

Fix incorrect unmounted state update warning #18617

merged 3 commits into from
Apr 18, 2020

Commits on Apr 17, 2020

  1. Fix incorrect unmounted state update warning 

    We detach fibers (which nulls the  field) when we commit a deletion, so any state updates scheduled between that point and when we eventually flush passive effect destroys won't have a way to check if there is a pending passive unmount effect scheduled for its alternate unless we also explicitly track the alternates.
    Brian Vaughn committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    57164f2 View commit details
    Browse the repository at this point in the history

  2. Use effectTag to suppress unmounted state update warnings 

    dquote>
dquote> Replace the separate current and alternate arrays with a new effect tag, PassiveUnmountPending, that we use to check for the case where a state update is scheduled for an unmoutned component that has a pending passive effect cleanup scheduled.
    Brian Vaughn committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    5223a07 View commit details
    Browse the repository at this point in the history

  3. Added "Dev" suffice to PendingPassiveUnmountDev flag

    Brian Vaughn committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    4537c13 View commit details
    Browse the repository at this point in the history