Disable ViewportMetrics unless MouseEvent lacks support for pageX/pageY #2271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1300, only IE8 lacks
pageX
/pageY
(and perhaps really old FF or w/e I guess).From my #1300 (comment):
https://github.com/facebook/react/blob/master/src/browser/ui/ReactEventListener.js#L65
https://github.com/facebook/react/blob/master/src/browser/ui/ReactEventListener.js#L165
That makes no sense at all to me,
refresh
does not take an argument, yet we get the scroll position and provide it as an argument. Instead,refresh
gets the scroll position internally and uses that? So we callgetUnboundedScrollPosition
twice, but only use the result once (also, this should be broken for events inside iframes, for IE8).https://github.com/facebook/react/blob/master/src/browser/eventPlugins/TapEventPlugin.js#L54
I'm pretty sure any browsers that supports touch also supports
pageX
/pageY
... ?