-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable ViewportMetrics unless MouseEvent lacks support for pageX/pageY #6129
Conversation
Disable ViewportMetrics unless MouseEvent lacks support for pageX/pageY
👍 |
Oops, I merged before it linted. |
@zpao Can we pick this into the next patch? @axemclion asked me about it today. |
@spicyj This shipped in 15.0.0 (in the RCs even)… what issue are you guys seeing? |
Oh, my mistake. I thought I verified it hadn't been picked but I just checked again and it does look okay. @axemclion Can you let us know if you're still seeing a scroll listener added? |
@spicyj I just tested this in Chrome. |
@spicyj I am using React 15.3.1 and for some reason, I was still seeing the scroll event handler being added. The stack trace shows that it is from here. Looks like this was because I was using JSDOM in my renderer and the change from this condition was not being me. So yes, this is fixed and we no longer have a scroll handler. |
This rebases #2271 by @syranide which fixes #1300.
The only change in the rebase is that the file moved.
I haven’t changed the logic.
@spicyj cleaned up the callsites internally so this should be good.