Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yarn to version Berry #24301

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Update Yarn to version Berry #24301

wants to merge 10 commits into from

Conversation

tiziodcaio
Copy link

@tiziodcaio tiziodcaio commented Apr 7, 2022

Summary

I upgraded to yarn v4.0.0, which would not work anymore on nodejs <18.

How did you test this change?

Not everything works at the moment so I make the PR a draft.

Current Issues:

@kachkaev
Copy link

kachkaev commented Apr 8, 2022

Upgrading to Yarn 3 is blocked by the lack of Dependabot support: dependabot/dependabot-core#1297

@tiziodcaio
Copy link
Author

Upgrading to Yarn 3 is blocked by the lack of Dependabot support: dependabot/dependabot-core#1297

Ok no problem, meanwhile I will fix workflows...

Can I suggest yarn upgrade-interactive as an alternative solution?

@sizebot
Copy link

sizebot commented Apr 8, 2022

Comparing: 2655c93...7f9136f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.33 kB 154.33 kB = 48.98 kB 48.98 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.25 kB 156.25 kB = 49.60 kB 49.60 kB
facebook-www/ReactDOM-prod.classic.js = 533.14 kB 533.14 kB = 94.42 kB 94.42 kB
facebook-www/ReactDOM-prod.modern.js = 518.24 kB 518.24 kB = 92.24 kB 92.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 533.14 kB 533.14 kB = 94.42 kB 94.42 kB
oss-experimental/react/unstable-cache.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable-semver/react/unstable-cache.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable/react/unstable-cache.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable-semver/react-is/umd/react-is.production.min.js = 2.31 kB 0.41 kB = 0.87 kB 0.28 kB
oss-stable/react-is/umd/react-is.production.min.js = 2.31 kB 0.41 kB = 0.87 kB 0.28 kB
oss-experimental/react-is/umd/react-is.production.min.js = 2.34 kB 0.41 kB = 0.87 kB 0.28 kB
oss-stable-semver/react-is/cjs/react-is.production.min.js = 2.27 kB 0.32 kB = 0.78 kB 0.23 kB
oss-stable/react-is/cjs/react-is.production.min.js = 2.27 kB 0.32 kB = 0.78 kB 0.23 kB
oss-experimental/react-is/cjs/react-is.production.min.js = 2.30 kB 0.32 kB = 0.79 kB 0.23 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 4.78 kB 0.32 kB = 1.15 kB 0.24 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 4.78 kB 0.32 kB = 1.15 kB 0.24 kB
facebook-www/ReactIs-prod.classic.js = 5.35 kB 0.34 kB = 1.31 kB 0.25 kB
facebook-www/ReactIs-prod.modern.js = 5.35 kB 0.34 kB = 1.31 kB 0.25 kB
oss-stable-semver/react-is/umd/react-is.development.js = 7.88 kB 0.45 kB = 2.09 kB 0.29 kB
oss-stable/react-is/umd/react-is.development.js = 7.88 kB 0.45 kB = 2.09 kB 0.29 kB
oss-experimental/react-is/umd/react-is.development.js = 7.90 kB 0.45 kB = 2.10 kB 0.29 kB
oss-stable-semver/react-is/cjs/react-is.development.js = 7.33 kB 0.41 kB = 2.01 kB 0.28 kB
oss-stable/react-is/cjs/react-is.development.js = 7.33 kB 0.41 kB = 2.01 kB 0.28 kB
oss-experimental/react-is/cjs/react-is.development.js = 7.35 kB 0.41 kB = 2.01 kB 0.28 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 7.25 kB 0.39 kB = 1.92 kB 0.28 kB
facebook-www/ReactIs-dev.modern.js = 9.56 kB 0.40 kB = 2.53 kB 0.29 kB
facebook-www/ReactIs-dev.classic.js = 9.56 kB 0.40 kB = 2.54 kB 0.29 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react/unstable-cache.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable-semver/react/unstable-cache.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable/react/unstable-cache.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable-semver/react-is/umd/react-is.production.min.js = 2.31 kB 0.41 kB = 0.87 kB 0.28 kB
oss-stable/react-is/umd/react-is.production.min.js = 2.31 kB 0.41 kB = 0.87 kB 0.28 kB
oss-experimental/react-is/umd/react-is.production.min.js = 2.34 kB 0.41 kB = 0.87 kB 0.28 kB
oss-stable-semver/react-is/cjs/react-is.production.min.js = 2.27 kB 0.32 kB = 0.78 kB 0.23 kB
oss-stable/react-is/cjs/react-is.production.min.js = 2.27 kB 0.32 kB = 0.78 kB 0.23 kB
oss-experimental/react-is/cjs/react-is.production.min.js = 2.30 kB 0.32 kB = 0.79 kB 0.23 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 4.78 kB 0.32 kB = 1.15 kB 0.24 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 4.78 kB 0.32 kB = 1.15 kB 0.24 kB
facebook-www/ReactIs-prod.classic.js = 5.35 kB 0.34 kB = 1.31 kB 0.25 kB
facebook-www/ReactIs-prod.modern.js = 5.35 kB 0.34 kB = 1.31 kB 0.25 kB
oss-stable-semver/react-is/umd/react-is.development.js = 7.88 kB 0.45 kB = 2.09 kB 0.29 kB
oss-stable/react-is/umd/react-is.development.js = 7.88 kB 0.45 kB = 2.09 kB 0.29 kB
oss-experimental/react-is/umd/react-is.development.js = 7.90 kB 0.45 kB = 2.10 kB 0.29 kB
oss-stable-semver/react-is/cjs/react-is.development.js = 7.33 kB 0.41 kB = 2.01 kB 0.28 kB
oss-stable/react-is/cjs/react-is.development.js = 7.33 kB 0.41 kB = 2.01 kB 0.28 kB
oss-experimental/react-is/cjs/react-is.development.js = 7.35 kB 0.41 kB = 2.01 kB 0.28 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 7.25 kB 0.39 kB = 1.92 kB 0.28 kB
facebook-www/ReactIs-dev.modern.js = 9.56 kB 0.40 kB = 2.53 kB 0.29 kB
facebook-www/ReactIs-dev.classic.js = 9.56 kB 0.40 kB = 2.54 kB 0.29 kB

Generated by 🚫 dangerJS against 7f9136f

@tiziodcaio
Copy link
Author

Upgrading to Yarn 3 is blocked by the lack of Dependabot support: dependabot/dependabot-core#1297

That's not true... I didn't enable pnp so there would not be problems with this type of issue.

@tiziodcaio
Copy link
Author

Now we should understanding what fails on the remaining workflows

@tiziodcaio tiziodcaio marked this pull request as draft April 14, 2022 14:19
@kachkaev
Copy link

Dependabot is not compatible with Yarn 3’s yarn.lock format. Unfortunately, it does not work with nodeLinker: node-modules too.

@larixer
Copy link

larixer commented Nov 15, 2022

Update. Dependabot had started to support Yarn 2+ since 20 Oct 2022:
https://github.blog/changelog/2022-10-20-dependabot-can-now-generate-security-and-version-updates-for-yarn-v2-and-v3/
Also the issue for Yarn 3 support in dependabot is now closed:
dependabot/dependabot-core#5322

Edit. Though at the time being there are still many pending issues with basic Yarn 2+ features:
dependabot/dependabot-core#6092
dependabot/dependabot-core#6107

@tiziodcaio
Copy link
Author

Update. Dependabot had started to support Yarn 2+ since 20 Oct 2022: https://github.blog/changelog/2022-10-20-dependabot-can-now-generate-security-and-version-updates-for-yarn-v2-and-v3/ Also the issue for Yarn 3 support in dependabot is now closed: dependabot/dependabot-core#5322

Edit. Though at the time being there are still many pending issues with basic Yarn 2+ features: dependabot/dependabot-core#6092 dependabot/dependabot-core#6107

Great! I wasn't more following this pr, now i will rebase, let's see what's happening with yarn 4 too

.yarnrc.yml Outdated Show resolved Hide resolved
.yarnrc.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Aug 3, 2024
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 11:11am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants