Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yarn to version Berry #24301

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .codesandbox/ci.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"packages": ["packages/react", "packages/react-dom", "packages/scheduler"],
"packages": [
"packages/react",
"packages/react-dom",
"packages/scheduler"
],
"buildCommand": "download-build-in-codesandbox-ci",
"node": "18",
"publishDirectory": {
Expand Down
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Third party
**/node_modules
.yarn

# Not written by hand
packages/react-art/npm/lib
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/compiler_playground.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand All @@ -39,10 +40,10 @@ jobs:
path: "**/node_modules"
key: compiler-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('compiler/**/yarn.lock') }}
- name: yarn install compiler
run: yarn install --frozen-lockfile
run: yarn
working-directory: compiler
- name: yarn install playground
run: yarn install --frozen-lockfile
run: yarn
- run: npx playwright install --with-deps chromium
- run: yarn test
- name: Archive test results
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/compiler_prereleases.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand All @@ -48,7 +49,7 @@ jobs:
with:
path: "**/node_modules"
key: compiler-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('compiler/**/yarn.lock') }}
- run: yarn install --frozen-lockfile
- run: yarn
- name: Publish packages to npm
run: |
cp ./scripts/release/ci-npmrc ~/.npmrc
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/compiler_typescript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand All @@ -48,7 +49,7 @@ jobs:
with:
path: "**/node_modules"
key: compiler-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('compiler/**/yarn.lock') }}
- run: yarn install --frozen-lockfile
- run: yarn
- run: yarn workspace babel-plugin-react-compiler lint

# Hardcoded to improve parallelism
Expand All @@ -57,6 +58,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand All @@ -68,7 +70,7 @@ jobs:
with:
path: "**/node_modules"
key: compiler-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('compiler/**/yarn.lock') }}
- run: yarn install --frozen-lockfile
- run: yarn
- run: yarn workspace babel-plugin-react-compiler jest

test:
Expand All @@ -81,6 +83,7 @@ jobs:
workspace_name: ${{ fromJSON(needs.discover_yarn_workspaces.outputs.matrix) }}
steps:
- uses: actions/checkout@v4
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand All @@ -92,5 +95,5 @@ jobs:
with:
path: "**/node_modules"
key: compiler-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('compiler/**/yarn.lock') }}
- run: yarn install --frozen-lockfile
- run: yarn
- run: yarn workspace ${{ matrix.workspace_name }} test
13 changes: 8 additions & 5 deletions .github/workflows/devtools_regression_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand All @@ -31,8 +32,7 @@ jobs:
with:
path: "**/node_modules"
key: runtime-release-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock', 'scripts/release/yarn.lock') }}
- run: yarn install --frozen-lockfile
- run: yarn install --frozen-lockfile
- run: yarn
working-directory: scripts/release
- name: Download react-devtools artifacts for base revision
run: |
Expand All @@ -52,6 +52,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand All @@ -63,7 +64,7 @@ jobs:
with:
path: "**/node_modules"
key: runtime-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
- run: yarn install --frozen-lockfile
- run: yarn
- name: Restore archived build
uses: actions/download-artifact@v4
with:
Expand Down Expand Up @@ -107,6 +108,7 @@ jobs:
continue-on-error: true
steps:
- uses: actions/checkout@v4
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand All @@ -118,7 +120,7 @@ jobs:
with:
path: "**/node_modules"
key: runtime-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
- run: yarn install --frozen-lockfile
- run: yarn
- name: Restore all archived build artifacts
uses: actions/download-artifact@v4
- name: Display structure of build
Expand All @@ -141,6 +143,7 @@ jobs:
continue-on-error: true
steps:
- uses: actions/checkout@v4
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand All @@ -152,7 +155,7 @@ jobs:
with:
path: "**/node_modules"
key: runtime-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
- run: yarn install --frozen-lockfile
- run: yarn
- name: Restore all archived build artifacts
uses: actions/download-artifact@v4
- name: Display structure of build
Expand Down
Loading