Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate missing static flag check #24525

Closed
wants to merge 1 commit into from

Conversation

rickhanlonii
Copy link
Member

Overview

This check was added in #20807 and is intended for in progress static flag work.

Currently, it fires even when hook counts change from 0 to n > 0. We should warn for that separately, but it also shouldn't fire this warning.

Related: #24391

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 9, 2022
@sizebot
Copy link

sizebot commented May 9, 2022

Comparing: d20c3af...26d16a0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.58 kB 131.58 kB = 42.15 kB 42.15 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.82 kB 136.82 kB = 43.70 kB 43.70 kB
facebook-www/ReactDOM-prod.classic.js = 440.68 kB 440.68 kB = 80.35 kB 80.34 kB
facebook-www/ReactDOM-prod.modern.js = 425.89 kB 425.89 kB = 78.17 kB 78.17 kB
facebook-www/ReactDOMForked-prod.classic.js = 440.68 kB 440.68 kB = 80.35 kB 80.35 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 26d16a0

@rickhanlonii
Copy link
Member Author

Update: After we have #24535, we can just check that that warning has been shown as a way to suppress this.

@rickhanlonii
Copy link
Member Author

Replaced by #24535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants