Reduce install network flake #27464

eps1lon · 2023-10-04T23:25:43Z

Summary

Avoids potentially flaky network calls leading to failures such as https://app.circleci.com/pipelines/github/facebook/react/47096/workflows/b7966c1d-199c-4185-8d17-ac6485235c3a/jobs/727782. Also makes install faster since we don't need the binary in CI seemingly.

Electron itself is used to start the standalone binary.

How did you test this change?

CI still passes without the binary downloaded. I'm just trusting their docs here that setting this actually ensures the binary isn't downloaded.

react-sizebot · 2023-10-04T23:31:21Z

Comparing: 0fba3ec...a19776c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	174.46 kB	174.46 kB	=	54.27 kB	54.27 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	176.31 kB	176.31 kB	=	54.88 kB	54.88 kB
facebook-www/ReactDOM-prod.classic.js	=	564.48 kB	564.48 kB	=	99.37 kB	99.37 kB
facebook-www/ReactDOM-prod.modern.js	=	548.21 kB	548.21 kB	=	96.44 kB	96.44 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against a19776c

hoxyq

Great, I don't think we use electron at any stage on CI.

## Summary Avoids potentially flaky network calls leading to failures such as https://app.circleci.com/pipelines/github/facebook/react/47096/workflows/b7966c1d-199c-4185-8d17-ac6485235c3a/jobs/727782. Also makes install faster since we don't need the binary in CI seemingly. Electron itself is used to start the standalone binary. ## How did you test this change? - [x] CI still passes without the binary downloaded. I'm just trusting [their docs](https://www.electronjs.org/docs/latest/tutorial/installation) here that setting this actually ensures the binary isn't downloaded.

…experimental prefix for server action APIs (#56809) The latest React canary builds have a few changes that need to be adopted for compatability. 1. the `useFormState` and `useFormStatus` hooks in `react-dom` and the `formData` opiont in `react-dom/server` are no longer prefixed with `experimental_` 2. server content (an undocumented React feature) has been removed. Next only had trivial intenral use of this API and did not expose a coherent feature to Next users (no ability to seed context on refetches). It is still possible that some users used the React server context APIs which is why this should go into Next 14. ### React upstream changes - facebook/react#27513 - facebook/react#27514 - facebook/react#27511 - facebook/react#27508 - facebook/react#27502 - facebook/react#27474 - facebook/react#26789 - facebook/react#27500 - facebook/react#27488 - facebook/react#27458 - facebook/react#27471 - facebook/react#27470 - facebook/react#27464 - facebook/react#27456 - facebook/react#27462 - facebook/react#27461 - facebook/react#27460 - facebook/react#27459 - facebook/react#27454 - facebook/react#27457 - facebook/react#27453 - facebook/react#27401 - facebook/react#27443 - facebook/react#27445 - facebook/react#27364 - facebook/react#27440 - facebook/react#27436 --------- Co-authored-by: Zack Tanner <zacktanner@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Jiachi Liu <inbox@huozhi.im>

## Summary Avoids potentially flaky network calls leading to failures such as https://app.circleci.com/pipelines/github/facebook/react/47096/workflows/b7966c1d-199c-4185-8d17-ac6485235c3a/jobs/727782. Also makes install faster since we don't need the binary in CI seemingly. Electron itself is used to start the standalone binary. ## How did you test this change? - [x] CI still passes without the binary downloaded. I'm just trusting [their docs](https://www.electronjs.org/docs/latest/tutorial/installation) here that setting this actually ensures the binary isn't downloaded.

## Summary Avoids potentially flaky network calls leading to failures such as https://app.circleci.com/pipelines/github/facebook/react/47096/workflows/b7966c1d-199c-4185-8d17-ac6485235c3a/jobs/727782. Also makes install faster since we don't need the binary in CI seemingly. Electron itself is used to start the standalone binary. ## How did you test this change? - [x] CI still passes without the binary downloaded. I'm just trusting [their docs](https://www.electronjs.org/docs/latest/tutorial/installation) here that setting this actually ensures the binary isn't downloaded. DiffTrain build for commit 16619f1.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 4, 2023

Reduce install network flake

a19776c

eps1lon force-pushed the test/ci-electron branch from 73c59b4 to a19776c Compare October 4, 2023 23:27

eps1lon marked this pull request as ready for review October 4, 2023 23:36

eps1lon requested review from hoxyq and kassens October 4, 2023 23:37

hoxyq approved these changes Oct 5, 2023

View reviewed changes

eps1lon merged commit 16619f1 into facebook:main Oct 5, 2023
36 checks passed

eps1lon deleted the test/ci-electron branch October 5, 2023 09:37

shuding mentioned this pull request Oct 11, 2023

Upgrade vendored React vercel/next.js#56705

Closed

gnoff mentioned this pull request Oct 13, 2023

Update React from d900fadbf to 09fbee89d. Removes server context and experimental prefix for server action APIs vercel/next.js#56809

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce install network flake #27464

Reduce install network flake #27464

eps1lon commented Oct 4, 2023 •

edited

Loading

react-sizebot commented Oct 4, 2023

hoxyq left a comment

Reduce install network flake #27464

Reduce install network flake #27464

Conversation

eps1lon commented Oct 4, 2023 • edited Loading

Summary

How did you test this change?

react-sizebot commented Oct 4, 2023

Critical size changes

Significant size changes

hoxyq left a comment

Choose a reason for hiding this comment

eps1lon commented Oct 4, 2023 •

edited

Loading