Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ServerContext in canary #27474

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

sebmarkbage
Copy link
Collaborator

We previously added a warning in #27424. This just removes it from canary/stable channels but keeps it in experimental for now.

@sebmarkbage sebmarkbage requested review from gnoff and acdlite October 6, 2023 18:41
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 6, 2023
@react-sizebot
Copy link

react-sizebot commented Oct 6, 2023

Comparing: dddfe68...95c9a57

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 174.46 kB 174.33 kB = 54.27 kB 54.27 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 176.31 kB 176.31 kB = 54.88 kB 54.88 kB
facebook-www/ReactDOM-prod.classic.js = 564.48 kB 564.12 kB = 99.37 kB 99.26 kB
facebook-www/ReactDOM-prod.modern.js = 548.21 kB 547.97 kB = 96.44 kB 96.34 kB
facebook-www/React-dev.classic.js = 127.12 kB 124.23 kB = 33.68 kB 32.84 kB
facebook-www/React-dev.modern.js = 126.03 kB 123.14 kB = 33.44 kB 32.59 kB
facebook-react-native/react/cjs/React-dev.js = 119.02 kB 116.13 kB = 31.45 kB 30.59 kB
oss-stable/react/cjs/react.development.js = 100.20 kB 97.35 kB = 27.09 kB 26.33 kB
oss-stable-semver/react/cjs/react.development.js = 100.18 kB 97.32 kB = 27.06 kB 26.30 kB
oss-stable/react/umd/react.development.js = 104.92 kB 101.92 kB = 27.25 kB 26.47 kB
oss-stable-semver/react/umd/react.development.js = 104.90 kB 101.90 kB = 27.22 kB 26.44 kB
oss-stable/react/cjs/react.shared-subset.development.js = 84.51 kB 81.82 kB = 23.45 kB 22.69 kB
oss-stable-semver/react/cjs/react.shared-subset.development.js = 84.48 kB 81.79 kB = 23.42 kB 22.66 kB
oss-stable/react/cjs/react.shared-subset.production.min.js = 7.89 kB 7.40 kB = 3.29 kB 3.13 kB
oss-stable-semver/react/cjs/react.shared-subset.production.min.js = 7.86 kB 7.38 kB = 3.27 kB 3.10 kB
facebook-www/React-profiling.classic.js = 21.29 kB 19.94 kB = 5.34 kB 5.07 kB
oss-stable/react/umd/react.production.min.js = 8.39 kB 7.86 kB = 3.25 kB 3.11 kB
oss-stable/react/umd/react.profiling.min.js = 8.39 kB 7.86 kB = 3.25 kB 3.11 kB
oss-stable-semver/react/umd/react.production.min.js = 8.36 kB 7.83 kB = 3.23 kB 3.08 kB
oss-stable-semver/react/umd/react.profiling.min.js = 8.36 kB 7.83 kB = 3.23 kB 3.09 kB
facebook-www/React-profiling.modern.js = 21.00 kB 19.65 kB = 5.26 kB 5.00 kB
oss-stable/react/cjs/react.production.min.js = 8.39 kB 7.85 kB = 3.18 kB 3.04 kB
oss-stable-semver/react/cjs/react.production.min.js = 8.36 kB 7.82 kB = 3.16 kB 3.01 kB
facebook-react-native/react/cjs/React-profiling.js = 20.73 kB 19.38 kB = 5.23 kB 4.96 kB
facebook-www/React-prod.classic.js = 20.68 kB 19.34 kB = 5.21 kB 4.95 kB
facebook-react-native/react/cjs/React-prod.js = 20.42 kB 19.07 kB = 5.17 kB 4.91 kB
facebook-www/React-prod.modern.js = 20.39 kB 19.04 kB = 5.13 kB 4.87 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/JSXDEVRuntime-dev.classic.js = 45.15 kB 44.92 kB = 12.82 kB 12.77 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 45.15 kB 44.92 kB = 12.82 kB 12.77 kB
oss-stable-semver/react/cjs/react-jsx-runtime.development.js = 43.94 kB 43.71 kB = 12.83 kB 12.78 kB
oss-stable/react/cjs/react-jsx-runtime.development.js = 43.94 kB 43.71 kB = 12.83 kB 12.78 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js = 43.35 kB 43.11 kB = 12.65 kB 12.61 kB
oss-stable/react/cjs/react-jsx-dev-runtime.development.js = 43.35 kB 43.11 kB = 12.65 kB 12.61 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 37.62 kB 37.40 kB = 10.83 kB 10.79 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 37.02 kB 36.80 kB = 10.66 kB 10.61 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.development.js = 18.56 kB 18.32 kB = 5.33 kB 5.28 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.development.js = 18.56 kB 18.32 kB = 5.33 kB 5.28 kB
facebook-www/React-dev.classic.js = 127.12 kB 124.23 kB = 33.68 kB 32.84 kB
facebook-www/React-dev.modern.js = 126.03 kB 123.14 kB = 33.44 kB 32.59 kB
facebook-react-native/react/cjs/React-dev.js = 119.02 kB 116.13 kB = 31.45 kB 30.59 kB
oss-stable/react/cjs/react.development.js = 100.20 kB 97.35 kB = 27.09 kB 26.33 kB
oss-stable-semver/react/cjs/react.development.js = 100.18 kB 97.32 kB = 27.06 kB 26.30 kB
oss-stable/react/umd/react.development.js = 104.92 kB 101.92 kB = 27.25 kB 26.47 kB
oss-stable-semver/react/umd/react.development.js = 104.90 kB 101.90 kB = 27.22 kB 26.44 kB
oss-stable/react/cjs/react.shared-subset.development.js = 84.51 kB 81.82 kB = 23.45 kB 22.69 kB
oss-stable-semver/react/cjs/react.shared-subset.development.js = 84.48 kB 81.79 kB = 23.42 kB 22.66 kB
oss-stable/react/cjs/react.shared-subset.production.min.js = 7.89 kB 7.40 kB = 3.29 kB 3.13 kB
oss-stable-semver/react/cjs/react.shared-subset.production.min.js = 7.86 kB 7.38 kB = 3.27 kB 3.10 kB
facebook-www/React-profiling.classic.js = 21.29 kB 19.94 kB = 5.34 kB 5.07 kB
oss-stable/react/umd/react.production.min.js = 8.39 kB 7.86 kB = 3.25 kB 3.11 kB
oss-stable/react/umd/react.profiling.min.js = 8.39 kB 7.86 kB = 3.25 kB 3.11 kB
oss-stable-semver/react/umd/react.production.min.js = 8.36 kB 7.83 kB = 3.23 kB 3.08 kB
oss-stable-semver/react/umd/react.profiling.min.js = 8.36 kB 7.83 kB = 3.23 kB 3.09 kB
facebook-www/React-profiling.modern.js = 21.00 kB 19.65 kB = 5.26 kB 5.00 kB
oss-stable/react/cjs/react.production.min.js = 8.39 kB 7.85 kB = 3.18 kB 3.04 kB
oss-stable-semver/react/cjs/react.production.min.js = 8.36 kB 7.82 kB = 3.16 kB 3.01 kB
facebook-react-native/react/cjs/React-profiling.js = 20.73 kB 19.38 kB = 5.23 kB 4.96 kB
facebook-www/React-prod.classic.js = 20.68 kB 19.34 kB = 5.21 kB 4.95 kB
facebook-react-native/react/cjs/React-prod.js = 20.42 kB 19.07 kB = 5.17 kB 4.91 kB
facebook-www/React-prod.modern.js = 20.39 kB 19.04 kB = 5.13 kB 4.87 kB

Generated by 🚫 dangerJS against 95c9a57

@sebmarkbage sebmarkbage force-pushed the disableservercontext branch from 331cc6a to 95c9a57 Compare October 6, 2023 19:02
@sebmarkbage sebmarkbage merged commit 1fc5828 into facebook:main Oct 11, 2023
github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
We previously added a warning in #27424. This just removes it from
canary/stable channels but keeps it in experimental for now.

DiffTrain build for [1fc5828](1fc5828)
alunyov pushed a commit to alunyov/react that referenced this pull request Oct 11, 2023
We previously added a warning in facebook#27424. This just removes it from
canary/stable channels but keeps it in experimental for now.
ztanner added a commit to vercel/next.js that referenced this pull request Oct 16, 2023
…experimental prefix for server action APIs (#56809)

The latest React canary builds have a few changes that need to be
adopted for compatability.

1. the `useFormState` and `useFormStatus` hooks in `react-dom` and the
`formData` opiont in `react-dom/server` are no longer prefixed with
`experimental_`
2. server content (an undocumented React feature) has been removed. Next
only had trivial intenral use of this API and did not expose a coherent
feature to Next users (no ability to seed context on refetches). It is
still possible that some users used the React server context APIs which
is why this should go into Next 14.

### React upstream changes

- facebook/react#27513
- facebook/react#27514
- facebook/react#27511
- facebook/react#27508
- facebook/react#27502
- facebook/react#27474
- facebook/react#26789
- facebook/react#27500
- facebook/react#27488
- facebook/react#27458
- facebook/react#27471
- facebook/react#27470
- facebook/react#27464
- facebook/react#27456
- facebook/react#27462
- facebook/react#27461
- facebook/react#27460
- facebook/react#27459
- facebook/react#27454
- facebook/react#27457
- facebook/react#27453
- facebook/react#27401
- facebook/react#27443
- facebook/react#27445
- facebook/react#27364
- facebook/react#27440
- facebook/react#27436

---------

Co-authored-by: Zack Tanner <zacktanner@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Jiachi Liu <inbox@huozhi.im>
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
We previously added a warning in facebook#27424. This just removes it from
canary/stable channels but keeps it in experimental for now.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
We previously added a warning in #27424. This just removes it from
canary/stable channels but keeps it in experimental for now.

DiffTrain build for commit 1fc5828.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants