Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update warnings extraction to hermes-parser #27785

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Dec 4, 2023

hermes-parser is recommended for all Flow files as it supports the latest features. I noticed we were still using babel here.

Test Plan:
no diff in output before and after

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 4, 2023
@kassens kassens merged commit f391cda into facebook:main Dec 4, 2023
27 checks passed
@kassens kassens deleted the warnings-parser branch December 4, 2023 18:25
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
`hermes-parser` is recommended for all Flow files as it supports the
latest features. I noticed we were still using babel here.

Test Plan:
no diff in output before and after
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
`hermes-parser` is recommended for all Flow files as it supports the
latest features. I noticed we were still using babel here.

Test Plan:
no diff in output before and after

DiffTrain build for commit f391cda.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants