Update .prettierrc.js #27732
Merged
Update .prettierrc.js #27732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsxBracketSameLine deprecated in v2.4.0 of Prettier, replaced by bracketSameLine. https://prettier.io/docs/en/options.html#deprecated-jsx-brackets
|
Comparing: bbb9cb1...c294962 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
Thank you! |
ztanner
added a commit
to vercel/next.js
that referenced
this pull request
Dec 15, 2023
Updates React from 2c338b16f to 0cdfef19b. ### React upstream changes - facebook/react#27821 - facebook/react#27820 - facebook/react#27818 - facebook/react#27819 - facebook/react#27817 - facebook/react#27703 - facebook/react#27796 - facebook/react#27811 - facebook/react#27804 - facebook/react#27807 - facebook/react#27805 - facebook/react#27792 - facebook/react#27788 - facebook/react#26852 - facebook/react#27790 - facebook/react#27786 - facebook/react#27785 - facebook/react#27783 - facebook/react#27784 - facebook/react#27769 - facebook/react#27766 - facebook/react#27701 - facebook/react#27732 - facebook/react#27740 - facebook/react#27767 - facebook/react#27768 - facebook/react#27765 - facebook/react#27759 - facebook/react#27579 - facebook/react#27709 - facebook/react#27734 - facebook/react#27739 - facebook/react#27717 - facebook/react#27583 - facebook/react#27713 Closes NEXT-1887
agustints
pushed a commit
to agustints/next.js
that referenced
this pull request
Jan 6, 2024
Updates React from 2c338b16f to 0cdfef19b. ### React upstream changes - facebook/react#27821 - facebook/react#27820 - facebook/react#27818 - facebook/react#27819 - facebook/react#27817 - facebook/react#27703 - facebook/react#27796 - facebook/react#27811 - facebook/react#27804 - facebook/react#27807 - facebook/react#27805 - facebook/react#27792 - facebook/react#27788 - facebook/react#26852 - facebook/react#27790 - facebook/react#27786 - facebook/react#27785 - facebook/react#27783 - facebook/react#27784 - facebook/react#27769 - facebook/react#27766 - facebook/react#27701 - facebook/react#27732 - facebook/react#27740 - facebook/react#27767 - facebook/react#27768 - facebook/react#27765 - facebook/react#27759 - facebook/react#27579 - facebook/react#27709 - facebook/react#27734 - facebook/react#27739 - facebook/react#27717 - facebook/react#27583 - facebook/react#27713 Closes NEXT-1887
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
jsxBracketSameLine deprecated in v2.4.0 of Prettier, replaced by bracketSameLine. https://prettier.io/docs/en/options.html#deprecated-jsx-brackets <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> I've always wanted to contribute to open source, even if it's in the smallest way possible. Resolves deprecated feature with currently used version of Prettier (2.4+). Those doing things like using React as a reference for their ".prettierrc" files will be using the non-deprecated versions. ## How did you test this change? Modified line 969 of App.js to push </h1> to line 971, saved the file, then ran "yarn prettier" and formatting returned it to original position confirming that jsxBracketSameLine acts in the same fashion to bracketSameLine, but also is no longer deprecated that has additional features which may be useful in the future to the project. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> λ yarn prettier yarn run v1.22.19 $ node ./scripts/prettier/index.js write-changed > git merge-base HEAD main > git diff --name-only --diff-filter=ACMRTUB bbb9cb1 > git ls-files --others --exclude-standard Done in 1.52s.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
jsxBracketSameLine deprecated in v2.4.0 of Prettier, replaced by bracketSameLine. https://prettier.io/docs/en/options.html#deprecated-jsx-brackets <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> I've always wanted to contribute to open source, even if it's in the smallest way possible. Resolves deprecated feature with currently used version of Prettier (2.4+). Those doing things like using React as a reference for their ".prettierrc" files will be using the non-deprecated versions. ## How did you test this change? Modified line 969 of App.js to push </h1> to line 971, saved the file, then ran "yarn prettier" and formatting returned it to original position confirming that jsxBracketSameLine acts in the same fashion to bracketSameLine, but also is no longer deprecated that has additional features which may be useful in the future to the project. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> λ yarn prettier yarn run v1.22.19 $ node ./scripts/prettier/index.js write-changed > git merge-base HEAD main > git diff --name-only --diff-filter=ACMRTUB bbb9cb1 > git ls-files --others --exclude-standard Done in 1.52s. DiffTrain build for commit dc40571.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsxBracketSameLine deprecated in v2.4.0 of Prettier, replaced by bracketSameLine.
https://prettier.io/docs/en/options.html#deprecated-jsx-brackets
Summary
I've always wanted to contribute to open source, even if it's in the smallest way possible. Resolves deprecated feature with currently used version of Prettier (2.4+). Those doing things like using React as a reference for their ".prettierrc" files will be using the non-deprecated versions.
How did you test this change?
Modified line 969 of App.js to push to line 971, saved the file, then ran "yarn prettier" and formatting returned it to original position confirming that jsxBracketSameLine acts in the same fashion to bracketSameLine, but also is no longer deprecated that has additional features which may be useful in the future to the project.
λ yarn prettier
yarn run v1.22.19
$ node ./scripts/prettier/index.js write-changed