Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Remove sleep in manual release script #30613

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Aug 6, 2024

Stack from ghstack (oldest at bottom):

I originally added this prior to the compiler being OSS'd as a "just in
case" feature to panic cancel if something went wrong. Now that the
compiler is already launched this is unnecessary.

[ghstack-poisoned]
Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 6:45pm

[ghstack-poisoned]
@poteto poteto mentioned this pull request Aug 6, 2024
@poteto poteto merged commit 80f21c1 into gh/poteto/1/base Aug 6, 2024
19 checks passed
poteto added a commit that referenced this pull request Aug 6, 2024
I originally added this prior to the compiler being OSS'd as a "just in
case" feature to panic cancel if something went wrong. Now that the
compiler is already launched this is unnecessary.

ghstack-source-id: dd17dc8a331657ce23c0cbc012ba967cfc3b9542
Pull Request resolved: #30613
@poteto poteto deleted the gh/poteto/1/head branch August 6, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants