Skip to content

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Aug 13, 2025

We used to only include the message of the cause but the stack relevant as well and not noise that should be omitted.

@eps1lon eps1lon requested a review from sebmarkbage August 13, 2025 15:50
@meta-cla meta-cla bot added the CLA Signed label Aug 13, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 13, 2025
@react-sizebot
Copy link

Comparing: 534bed5...829a313

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.18 kB 530.18 kB = 93.39 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 654.55 kB 654.55 kB = 115.11 kB 115.11 kB
facebook-www/ReactDOM-prod.classic.js = 674.32 kB 674.32 kB = 118.29 kB 118.29 kB
facebook-www/ReactDOM-prod.modern.js = 664.74 kB 664.74 kB = 116.65 kB 116.65 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 829a313

@eps1lon eps1lon marked this pull request as ready for review August 13, 2025 15:54
@eps1lon eps1lon merged commit 379a083 into facebook:main Aug 13, 2025
250 checks passed
@eps1lon eps1lon deleted the sebbie/08-13-_devtools_include_stack_of_cause_in_react_instrumentation_errors branch August 13, 2025 17:18
github-actions bot pushed a commit that referenced this pull request Aug 13, 2025
github-actions bot pushed a commit that referenced this pull request Aug 13, 2025
github-actions bot pushed a commit to Umasankar15/react that referenced this pull request Aug 13, 2025
github-actions bot pushed a commit to Umasankar15/react that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants