Skip to content

Include stack of cause in React instrumentation errors #34198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
+9 −9
Merged

Include stack of cause in React instrumentation errors #34198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-client/src/ReactFlightClientDevToolsHook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function injectInternals(internals: Object): boolean {
} catch (err) {
// Catch all errors because it is unsafe to throw during initialization.
if (__DEV__) {
console.error('React instrumentation encountered an error: %s.', err);
console.error('React instrumentation encountered an error: %o.', err);
}
}
if (hook.checkDCE) {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-shared/src/__tests__/setupTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ function patchConsoleForTestingBeforeHookInstallation() {
// if they use this code path.
firstArg = firstArg.slice(9);
}
if (firstArg === 'React instrumentation encountered an error: %s') {
if (firstArg === 'React instrumentation encountered an error: %o') {
// Rethrow errors from React.
throw args[1];
} else if (
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-shared/src/backend/fiber/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2935,7 +2935,7 @@ export function attach(
}
if (suspenseNode.parent !== parentNode) {
throw new Error(
'Cannot remove a node from a different parent than is being reconciled.',
'Cannot remove a Suspense node from a different parent than is being reconciled.',
);
}
let previousSuspenseSibling = remainingReconcilingChildrenSuspenseNodes;
Expand Down
12 changes: 6 additions & 6 deletions packages/react-reconciler/src/ReactFiberDevToolsHook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export function injectInternals(internals: Object): boolean {
} catch (err) {
// Catch all errors because it is unsafe to throw during initialization.
if (__DEV__) {
console.error('React instrumentation encountered an error: %s.', err);
console.error('React instrumentation encountered an error: %o.', err);
}
}
if (hook.checkDCE) {
Expand All @@ -101,7 +101,7 @@ export function onScheduleRoot(root: FiberRoot, children: ReactNodeList) {
} catch (err) {
if (__DEV__ && !hasLoggedError) {
hasLoggedError = true;
console.error('React instrumentation encountered an error: %s', err);
console.error('React instrumentation encountered an error: %o', err);
}
}
}
Expand Down Expand Up @@ -144,7 +144,7 @@ export function onCommitRoot(root: FiberRoot, eventPriority: EventPriority) {
if (__DEV__) {
if (!hasLoggedError) {
hasLoggedError = true;
console.error('React instrumentation encountered an error: %s', err);
console.error('React instrumentation encountered an error: %o', err);
}
}
}
Expand All @@ -162,7 +162,7 @@ export function onPostCommitRoot(root: FiberRoot) {
if (__DEV__) {
if (!hasLoggedError) {
hasLoggedError = true;
console.error('React instrumentation encountered an error: %s', err);
console.error('React instrumentation encountered an error: %o', err);
}
}
}
Expand All @@ -177,7 +177,7 @@ export function onCommitUnmount(fiber: Fiber) {
if (__DEV__) {
if (!hasLoggedError) {
hasLoggedError = true;
console.error('React instrumentation encountered an error: %s', err);
console.error('React instrumentation encountered an error: %o', err);
}
}
}
Expand All @@ -199,7 +199,7 @@ export function setIsStrictModeForDevtools(newIsStrictMode: boolean) {
if (__DEV__) {
if (!hasLoggedError) {
hasLoggedError = true;
console.error('React instrumentation encountered an error: %s', err);
console.error('React instrumentation encountered an error: %o', err);
}
}
}
Expand Down
Loading