Rewrite vendor/constants.js to use require("recast").types.traverse #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 |
Most notably, this new style of transformation gives us access to this.parent.node, which allows us to avoid replacing identifiers that are not actually free variables, such as member expression properties. Closes facebook#496.
benjamn
added a commit
that referenced
this pull request
Nov 13, 2013
Rewrite vendor/constants.js to use require("recast").types.traverse.
benjamn
added a commit
to benjamn/react
that referenced
this pull request
Dec 4, 2013
Pull request facebook#526 updated the behavior of vendor/constants.js without changing any source files or the bin/jsx-internal script, so files that should have been rebuilt (like utils/__tests__/ImmutableObject-test.js) were not automatically rebuilt (unless you knew to do `grunt clean` or `rm -rf .module-cache` manually). This commit allows us to bump a version number when we know the transform toolchain has been altered in a way that will not be visible to commoner/jsx. With this convention, if we reset to an older revision (e.g. during a git bisect) and the appropriate cached module files are still in the .module-cache/, they can be used without rebuilding. That's why I prefer this approach to just deleting the .module-cache/. Closes facebook#104. Closes facebook#496. Closes facebook#530.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notably, this new style of transformation gives us access to
this.parent.node, which allows us to avoid replacing identifiers that are not actually free variables, such as member expression properties.Closes #496.