Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6049 add support for onCancel event #6247

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

ludvigsen
Copy link
Contributor

Adds support for the onCancel event described here: #6049

@facebook-github-bot
Copy link

@ludvigsen updated the pull request.

@ludvigsen ludvigsen force-pushed the 6049-onCancel-support branch 2 times, most recently from d3b8530 to 654b318 Compare March 11, 2016 20:32
@facebook-github-bot
Copy link

@ludvigsen updated the pull request.

@cbrwizard
Copy link

This might not be needed at all, but I think that this change will benefit from tests. Like in this file.

@ludvigsen
Copy link
Contributor Author

@cbrwizard I don't think jsdom supports the Dialog element, so testing this could prove an issue, at least through jsdom/jest.

@ghost ghost added the CLA Signed label Jul 12, 2016
@NoelBroda
Copy link

@ludvigsen ping

@vcanales
Copy link

vcanales commented Jan 2, 2017

@ludvigsen I took your code, rebased and fixed conflicts. I don't know if it helps but I'd at least like to give this issue a bit of visibility.

vcanales@1bca7a6

@ludvigsen
Copy link
Contributor Author

@devjunkORG Thanks, I appreciate it. Did you check to see if stuff still works as well?

Copy link
Contributor

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ludvigsen looks like there are a number of conflicts. Would you be able to resolve those? I'd like to make sure this gets in.

@aweary aweary self-assigned this Jan 26, 2017
@ludvigsen
Copy link
Contributor Author

@aweary Great! I'll try to resolve the conflicts.

@ludvigsen ludvigsen force-pushed the 6049-onCancel-support branch from 654b318 to 4cbc434 Compare January 26, 2017 22:54
@ludvigsen ludvigsen force-pushed the 6049-onCancel-support branch from 4cbc434 to 318563d Compare January 26, 2017 22:56
@ludvigsen
Copy link
Contributor Author

@aweary Resolved the conflicts also added onClose event for completeness

@aweary
Copy link
Contributor

aweary commented Jan 31, 2017

Thanks @ludvigsen! I verified locally that the events are being dispatched for onClose and onCancel with a <dialog /> element. This LGTM, thanks again!

@aweary aweary added this to the 15-lopri milestone Jan 31, 2017
@aweary aweary merged commit d845084 into facebook:master Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants