onCancel event

[tleunen]

I don't see the onCancel event in the list of supported events. Would it be possible to add it in the list?
It's used by the Dialog element, already available in Chrome.

[jimfb]

I think it would need to be added to the source code too.

[tleunen]

I wanted to do it, but I don't really know in which category we shoul put the close and cancel events used in the Dialog. In the UI category?

[jimfb]

It goes into the UI category if it has the detail and view properties. Otherwise, it would probably go into its own category.

[mxstbr]

Here is a JSFiddle with a dialog element and the close and cancel events for reference, works on my Chrome Canary 50.0.2651.0!

[syranide]

FYI, it's just an Event, no subcategory.

[ludvigsen]

Tried implementing support for this here:
#6247

Please let me know it i've made any mistakes :)

[cbrwizard]

Should React support for the onClose event too? It's also related to the dialog.

@ludvigsen you were faster than me, haha, grats =]. I've created an example page (took examples/basic/index.html as source) to test out new events on gist, you can check it out and use it for easier debugging.

[ludvigsen]

Thanks @cbrwizard! It seems like it would make a lot of sense to support the onClose event as well, I can definitely add it. Although in react I guess you would control the dialog through the "open" attribute, and therefore know when the user closed the dialog. Whereas the cancel event is fired if the user presses ESC, so the only way to know about it is to listen for it.

[tleunen]

Not really, because you can open a dialog as a normal dialog, or as a modal.

Afaik, there's no way with the attribute to open it as a modal.

[ludvigsen]

@tleunen thats true, would be nice if it was possible to control modal as well with an attribute.

[pranaygp]

Is there still a issue here, or should this be closed?

[aweary]

@pranaygp looks like this is still an outstanding issue. #6247 was opened to add onCancel, but it wasn't reviewed. At this point it would have some conflicts that need to be resolved before it can be merged.

[pranaygp]

@aweary thanks. I'll look into that PR and see if I can help

[ludvigsen]

@aweary will #6247 be merged if the conflicts (and other issues if there are any) are resolved?

[paulmanta]

I see that #6247 was merged, should this issue be closed?

[aweary]

It should, thank you!