facebook#6049 add support for onCancel and onClose event

ludvigsen · Jan 26, 2017 · 318563d · 318563d
1 parent 3c75593
commit 318563d
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/src/renderers/dom/shared/ReactBrowserEventEmitter.js b/src/renderers/dom/shared/ReactBrowserEventEmitter.js
@@ -87,10 +87,12 @@ var topEventMapping = {
   topAnimationIteration: getVendorPrefixedEventName('animationiteration') || 'animationiteration',
   topAnimationStart: getVendorPrefixedEventName('animationstart') || 'animationstart',
   topBlur: 'blur',
+  topCancel: 'cancel',
   topCanPlay: 'canplay',
   topCanPlayThrough: 'canplaythrough',
   topChange: 'change',
   topClick: 'click',
+  topClose: 'close',
   topCompositionEnd: 'compositionend',
   topCompositionStart: 'compositionstart',
   topCompositionUpdate: 'compositionupdate',
@@ -305,6 +307,24 @@ var ReactBrowserEventEmitter = Object.assign({}, ReactEventEmitterMixin, {
           // to make sure blur and focus event listeners are only attached once
           isListening.topBlur = true;
           isListening.topFocus = true;
+        } else if (dependency === 'topCancel') {
+          if (isEventSupported('cancel', true)) {
+            ReactBrowserEventEmitter.ReactEventListener.trapCapturedEvent(
+              'topCancel',
+              'cancel',
+              mountAt
+            );
+          }
+          isListening.topCancel = true;
+        } else if (dependency === 'topClose') {
+          if (isEventSupported('close', true)) {
+            ReactBrowserEventEmitter.ReactEventListener.trapCapturedEvent(
+              'topClose',
+              'close',
+              mountAt
+            );
+          }
+          isListening.topClose = true;
         } else if (topEventMapping.hasOwnProperty(dependency)) {
           ReactBrowserEventEmitter.ReactEventListener.trapBubbledEvent(
             dependency,

diff --git a/src/renderers/dom/shared/eventPlugins/SimpleEventPlugin.js b/src/renderers/dom/shared/eventPlugins/SimpleEventPlugin.js
@@ -65,9 +65,11 @@ var topLevelEventsToDispatchConfig: {[key: TopLevelTypes]: DispatchConfig} = {};
   'animationIteration',
   'animationStart',
   'blur',
+  'cancel',
   'canPlay',
   'canPlayThrough',
   'click',
+  'close',
   'contextMenu',
   'copy',
   'cut',
@@ -155,8 +157,10 @@ var SimpleEventPlugin: PluginModule<MouseEvent> = {
     var EventConstructor;
     switch (topLevelType) {
       case 'topAbort':
+      case 'topCancel':
       case 'topCanPlay':
       case 'topCanPlayThrough':
+      case 'topClose':
       case 'topDurationChange':
       case 'topEmptied':
       case 'topEncrypted':

diff --git a/src/renderers/shared/shared/event/EventConstants.js b/src/renderers/shared/shared/event/EventConstants.js
@@ -22,10 +22,12 @@ var topLevelTypes = {
   topAnimationIteration: null,
   topAnimationStart: null,
   topBlur: null,
+  topCancel: null,
   topCanPlay: null,
   topCanPlayThrough: null,
   topChange: null,
   topClick: null,
+  topClose: null,
   topCompositionEnd: null,
   topCompositionStart: null,
   topCompositionUpdate: null,