Clean up ReactTestRenderer #7716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
| @@ -7,6 +7,7 @@ | |||
| * of patent rights can be found in the PATENTS file in the same directory. | |||
| * | |||
| * @providesModule ReactTestRenderer | |||
| * @flow | |||
There was a problem hiding this comment.
@gaearon should I add flow as a separate PR? I know you mentioned keeping style changes separate from feature changes, but I wasn't sure where flow landed on that spectrum.
There was a problem hiding this comment.
Flow is fine now that we have a better idea how to use it thanks to PRs from @vjeux!
| mountComponent( | ||
| transaction: ReactTestReconcileTransaction, | ||
| nativeParent: null | ReactTestComponent, | ||
| nativeContainerInfo: ?null, |
There was a problem hiding this comment.
I wasn't too sure if I typed nativeParent and nativeContainerInfo correctly. From what I could tell, nativeParent is either null or another instance of ReactTestComponent, and nativeContainerInfo was either null or undefined.
There was a problem hiding this comment.
nativeContainerInfo was either null or undefined
haha, sounds about right.
|
Seems all right, thanks. |
This was referenced Sep 14, 2016
zpao
pushed a commit
that referenced
this pull request
Oct 4, 2016
* create ReactTestTextComponent fil * create ReactTestEmptyComponent * Use class for ReactTestRenderer * Add flow to ReactTestRenderer (cherry picked from commit 5a3abab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks out
ReactTestTextComponentandReactTestEmptyComponentinto their own files so the main ReactTestRenderer.js file is a little cleaner.I also implemented
ReactTestRendererwith an ES6 class + flow types.cc @gaearon @spicyj