Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ignores in flowconfig #7722

Merged
merged 1 commit into from
Sep 14, 2016
Merged

Update ignores in flowconfig #7722

merged 1 commit into from
Sep 14, 2016

Conversation

zpao
Copy link
Member

@zpao zpao commented Sep 13, 2016

This ensures we ignore relative to our project root and won't be tripped up by issues where checkouts in other places result in Flow passing when it shouldn't (eg on Travis CI where the checkout path is /home/travis/build/facebook/react)

This ensures we ignore relative to our project root and won't be tripped up by issues where checkouts in other places result in Flow passing when it shouldn't (eg on Travis CI where the checkout path is `/home/travis/build/facebook/react`)
@zpao zpao changed the title [ci] Diagnose silent flow failures Update ignores in flowconfig Sep 14, 2016
@zpao
Copy link
Member Author

zpao commented Sep 14, 2016

I tested this myself cloning to /tmp/build. I built so there was a build directory inside the checkout. I confirmed that Flow passed without any changes, though it should currently be failing. I then made an intermediate change to make sure changes to the build line would impact things and ended up with the whole build directory being included and causing problems. I then made the edit to end up here with <PROJECT_ROOT> and confirmed only the failures we want are in there. We should still make sure this actually works on Travis too but I expect this should be it.

In the future we might want to turn this around and only [include] paths explicitly instead of overloading the [ignore]s - probably a bit more resilient.

@zpao
Copy link
Member Author

zpao commented Sep 14, 2016

Well it worked… and it's catching a bunch of new failures beyond the ones that weren't there yesterday (mostly #7716 I think).

@sophiebits
Copy link
Collaborator

👍

@vjeux
Copy link
Contributor

vjeux commented Sep 14, 2016

/facepalm

@zpao zpao merged commit 864bc7b into facebook:master Sep 14, 2016
@zpao zpao modified the milestone: 15-next Sep 19, 2016
@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016
zpao added a commit that referenced this pull request Oct 4, 2016
This ensures we ignore relative to our project root and won't be tripped up by issues where checkouts in other places result in Flow passing when it shouldn't (eg on Travis CI where the checkout path is `/home/travis/build/facebook/react`)
(cherry picked from commit 864bc7b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants