Fix getRangeBehavior to allow non-string calls

Summary:
Fixes #1208

That `invariant` doesn't seem to make sense in that function, removing it will allow us to use `rangeBehavior` functions with other types than string.

josephsavona
Closes #1216

Reviewed By: wincent

Differential Revision: D3440535

Pulled By: kassens

fbshipit-source-id: 35038900382425843075de2c592cee0da2c566f1

src/mutation/__tests__/getRangeBehavior-test.js

@@ -28,6 +28,12 @@ describe('getRangeBehavior()', () => {
       const rangeBehavior = getRangeBehavior(rangeBehaviors, calls);
       expect(rangeBehavior).toBe('append');
     });
+
+    it('allows non-string values for call arguments', () => {
+      const calls = [{name: 'status', value: 1}];
+      const rangeBehavior = getRangeBehavior(rangeBehaviors, calls);
+      expect(rangeBehavior).toBe('refetch');
+    });
   });
 
   describe('when rangeBehaviors are a plain object', () => {

src/mutation/getRangeBehavior.js

@@ -14,6 +14,7 @@
 
 import type {
   Call,
+  CallValue,
   RangeBehaviors,
 } from 'RelayInternalTypes';
 
@@ -67,18 +68,10 @@ function getRangeBehavior(
 */
 function getObjectFromCalls(
   calls: Array<Call>
-): {[argName: string]: string} {
-  const behaviors = {};
+): {[argName: string]: CallValue} {
+  const behaviors: {[argName: string]: CallValue} = {};
   calls.forEach(call => {
-    const behavior = call.value;
-    invariant(
-      typeof behavior === 'string',
-      'getRangeBehavior(): Expected range behavior for key `%s` to be a ' +
-      'string, got `%s`.',
-      call.name,
-      behavior
-    );
-    behaviors[call.name] = behavior;
+    behaviors[call.name] = call.value;
   });
   return behaviors;
 }

src/tools/RelayInternalTypes.js

@@ -76,7 +76,7 @@ export type UpdateOptions = {
 };
 
 type RangeBehaviorsFunction = (
-  connectionArgs: {[argName: string]: string},
+  connectionArgs: {[argName: string]: CallValue},
 ) => $Keys<GraphQLMutatorConstants.RANGE_OPERATIONS>;
 
 type RangeBehaviorsObject = {