Fix getRangeBehavior to allow non-string calls #1216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thanks for the fix! I checked the internal discussion and it indeed seems like an oversight. Would you mind adding a test case to |
xuorig
force-pushed
the
fix-range-beha-fn
branch
from
25ce3a1 to
d74cb06
Compare
|
Added a regression test @kassens ! |
| behavior | ||
| ); | ||
| behaviors[call.name] = behavior; | ||
| behaviors[call.name] = call.value; |
There was a problem hiding this comment.
the return type of this function has to be changed to {[argName: string]: mixed}, since that's the type of call.value. not sure why flow isn't finding this.
|
@xuorig see comment about the return type |
|
I'll fix up the return type before merging this. @facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
|
Thanks @kassens ! |
|
I applied this patch locally to my copy of Relay and it fixed the problem for me. Thanks for fixing @xuorig! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1208
That
invariantdoesn't seem to make sense in that function, removing it will allow us to userangeBehaviorfunctions with other types than string.@josephsavona