Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_tools/build_detect_version rocksdb_build_git_sha #55

Closed
cxz19871115 opened this issue Jan 3, 2014 · 0 comments · Fixed by #56
Closed

build_tools/build_detect_version rocksdb_build_git_sha #55

cxz19871115 opened this issue Jan 3, 2014 · 0 comments · Fixed by #56

Comments

@cxz19871115
Copy link

18 env -i git rev-parse HEAD 2>&1 |
19 awk '
20 BEGIN {
21 print "#include "build_version.h"\n"
22 }
23 { print "const char* rocksdb_build_git_sha = "rocksdb_build_git_sha:" $0"";" }
24 ' > ${VFILE}

in my pc, exec "env -i git rev-parse HEAD" failed, print two lines info, like this.
$ env -i git rev-parse HEAD
fatal: Not a git repository (or any parent up to mount parent /mnt)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

It can print two 'const char* rocksdb_build_git_sha = "rocksdb_build_git_sha:XXX" ' into util/build_version.cc, so that redifinition error happened when compiled src.

I think it is a bug, must to check result of command "env -i git rev-parse HEAD", to make sure the resutl just only one line.

@liukai liukai closed this as completed in #56 Jan 6, 2014
DorianZheng added a commit to DorianZheng/rocksdb that referenced this issue Oct 17, 2018
DorianZheng added a commit to DorianZheng/rocksdb that referenced this issue Nov 24, 2018
DorianZheng added a commit to DorianZheng/rocksdb that referenced this issue Dec 10, 2018
DorianZheng added a commit to DorianZheng/rocksdb that referenced this issue Dec 10, 2018
ajkr pushed a commit to ajkr/rocksdb that referenced this issue Sep 18, 2019
Correctly handle FS that does not support hard links
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this issue Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant