Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build_tools/build_detect_version #56

Merged
merged 2 commits into from
Jan 6, 2014

Conversation

sepeth
Copy link
Contributor

@sepeth sepeth commented Jan 5, 2014

Fixes #55, and retains the fix for #11

  • I didn't use awk, same goal can be achieved with cat, and it seems easier to read.
  • Checking whether git exists is safer with "command -v"
  • Last check about build_version.cc is changed/missing is effectively the same with overriding it. I directly write the output to util/build_version.cc

@liukai
Copy link
Contributor

liukai commented Jan 6, 2014

New version looks much more clear, thank you!

liukai added a commit that referenced this pull request Jan 6, 2014
Refactor build_tools/build_detect_version
@liukai liukai merged commit be271c3 into facebook:master Jan 6, 2014
@sepeth sepeth deleted the refactor-detect-version branch January 6, 2014 19:52
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this pull request Sep 21, 2021
mayuehappy pushed a commit to mayuehappy/rocksdb that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_tools/build_detect_version rocksdb_build_git_sha
2 participants