Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve expected values file for failed crash tests #7530

Closed
ajkr opened this issue Oct 10, 2020 · 0 comments
Closed

Preserve expected values file for failed crash tests #7530

ajkr opened this issue Oct 10, 2020 · 0 comments
Assignees
@jay-zhuang
Labels
enhancement

Comments

@ajkr
Copy link
Contributor

ajkr commented Oct 10, 2020 •
edited
Loading

In crash tests ("tools/db_crashtest.py"), expected_values_file is assigned tempfile.NamedTemporaryFile(), which is deleted as soon as it's closed according to Python docs. For debugging corruptions, it'd be good to preserve this file when the crash test fails. That way we can rerun the final failed command using the same expected state that the failed command had, and hopefully repro the corruption.
@jay-zhuang jay-zhuang mentioned this issue Oct 11, 2020
Closed
@ajkr ajkr removed the up-for-grabs Up for grabs label Oct 12, 2020
jay-zhuang added a commit to jay-zhuang/rocksdb that referenced this issue Oct 12, 2020
@jay-zhuang
db_crashtest preserves expected values file for failed crash tests
0996901 
If crash test fails, don't delete the `expected_values_file` for later
debug. More details: facebook#7530

Test Plan: local host
facebook-github-bot pushed a commit that referenced this issue Oct 12, 2020
@jay-zhuang @facebook-github-bot
db_crashtest preserves expected values file for failed crash tests (#…
9e03e4d 
…7534)

Summary:
If crash test fails, don't delete the `expected_values_file` for later
debug. More details: #7530

Pull Request resolved: #7534

Test Plan: local host

Reviewed By: ajkr

Differential Revision: D24239655

Pulled By: jay-zhuang

fbshipit-source-id: 3566f91a30aae1e27d2f51d910cddd08edb7d4cf
codingrhythm pushed a commit to SafetyCulture/rocksdb that referenced this issue Mar 5, 2021
@jay-zhuang @codingrhythm
db_crashtest preserves expected values file for failed crash tests (f…
1cc7e83 
…acebook#7534)

Summary:
If crash test fails, don't delete the `expected_values_file` for later
debug. More details: facebook#7530

Pull Request resolved: facebook#7534

Test Plan: local host

Reviewed By: ajkr

Differential Revision: D24239655

Pulled By: jay-zhuang

fbshipit-source-id: 3566f91a30aae1e27d2f51d910cddd08edb7d4cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jay-zhuang jay-zhuang

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jay-zhuang @ajkr