Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db_crashtest preserves expected values file for failed crash tests #7534

Closed
wants to merge 2 commits into from
Closed

db_crashtest preserves expected values file for failed crash tests #7534

wants to merge 2 commits into from

Conversation

jay-zhuang
Copy link
Contributor

If crash test fails, don't delete the expected_values_file for later
debug. More details: #7530

Test Plan: local host

@jay-zhuang jay-zhuang requested a review from ajkr October 11, 2020 02:29
facebook-github-bot
facebook-github-bot reviewed Oct 11, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ajkr
ajkr approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fast fix!

BTW, there is an upload step for failed runs in CI (see internal wiki w MySQL/RocksDB/Oncall/Stress_test/). We might need to somehow add this file to include it in the tar.

@jay-zhuang
db_crashtest preserves expected values file for failed crash tests
0996901 
If crash test fails, don't delete the `expected_values_file` for later
debug. More details: facebook#7530

Test Plan: local host
@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@jay-zhuang
Copy link
Contributor Author

LGTM, thanks for the fast fix!

BTW, there is an upload step for failed runs in CI (see internal wiki w MySQL/RocksDB/Oncall/Stress_test/). We might need to somehow add this file to include it in the tar.

thanks for pointing out. Changed the expected_values_file the store place also to the same tmp_dir if it's specified. Then it will be upload together with db, also will be clean up together. for example, if the tmp dir is /tmp/rocksdb, it will create a db folder and a expected value file:

zjay@zjay-mbp /tmp/rocksdb% ll
total 0
-rw-r--r--  1 zjay  wheel     0B Oct 12 10:57 rocksdb_crashtest_expected
drwxr-xr-x  2 zjay  wheel    64B Oct 12 10:57 rocksdb_crashtest_whitebox

facebook-github-bot
facebook-github-bot reviewed Oct 12, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang merged this pull request in 9e03e4d.

codingrhythm pushed a commit to SafetyCulture/rocksdb that referenced this pull request Mar 5, 2021
@jay-zhuang @codingrhythm
db_crashtest preserves expected values file for failed crash tests (f…
1cc7e83 
…acebook#7534)

Summary:
If crash test fails, don't delete the `expected_values_file` for later
debug. More details: facebook#7530

Pull Request resolved: facebook#7534

Test Plan: local host

Reviewed By: ajkr

Differential Revision: D24239655

Pulled By: jay-zhuang

fbshipit-source-id: 3566f91a30aae1e27d2f51d910cddd08edb7d4cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ajkr ajkr ajkr approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jay-zhuang @facebook-github-bot @ajkr