Export GetCompactionReasonString/GetFlushReasonString by moving them into listener.h #11778
Conversation
Hi @mrambacher, thanks for your suggestion. Which file should I put those two functions? does it make sense to put them in listener.h? |
@git-hulk I would suggest the declaration be in listener.h, since that is where the enums are specified. |
Got it, thank you! |
git-hulk
force-pushed
the
export-reason-to-string-functions
branch
from
d8cdcfc to
56e6537
Compare
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: `GetCompactionReasonString()` will be exposed in RocksDB 8.7, which includes PR facebook/rocksdb#11778 that exposes it. So update its definition here to be based on RocksDB version. Differential Revision: D49755853 fbshipit-source-id: 1ff11f6708768b0039f88835e44272f525798ba2
Summary: `GetCompactionReasonString()` will be exposed in RocksDB 8.7, which includes PR facebook/rocksdb#11778 that exposes it. So update its definition here to be based on RocksDB version. Differential Revision: D49755853
…into listener.h (#11778) Summary: Currently, rocksdb users would use the event listener to catch the compaction/flush event and log them if any. But now the reason is an integer type instead of a human-readable string, so we would like to convert them into a human-readable string. Pull Request resolved: facebook/rocksdb#11778 Reviewed By: jaykorean Differential Revision: D49012934 Pulled By: ajkr fbshipit-source-id: a4935b95d70c1be02aec65da7bf1c98a8cf8b933
…into listener.h (#11778) Summary: Currently, rocksdb users would use the event listener to catch the compaction/flush event and log them if any. But now the reason is an integer type instead of a human-readable string, so we would like to convert them into a human-readable string. Pull Request resolved: facebook/rocksdb#11778 Reviewed By: jaykorean Differential Revision: D49012934 Pulled By: ajkr fbshipit-source-id: a4935b95d70c1be02aec65da7bf1c98a8cf8b933
Currently, rocksdb users would use the event listener to catch the compaction/flush event and log them if any. But now the reason is an integer type instead of a human-readable string, so we would like to convert them into a human-readable string.