Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to_string about listeners enum classes #11791

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support to_string about listeners enum classes #11791

wants to merge 2 commits into from

Conversation

darionyaphet
Copy link
Contributor

No description provided.

mrambacher
mrambacher reviewed Sep 4, 2023
View reviewed changes
Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better suited to an (non-inline) API like "GetStringFromCompactionReason". A similar API can be found in convenience.h for CompressionType.

@jowlyzhang
Copy link
Contributor

Just an FYI, #11778 was merged that does part of what this PR does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrambacher mrambacher mrambacher left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darionyaphet @jowlyzhang @mrambacher @facebook-github-bot