Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At first, I ran
CLANGTIDY
against the whole repo and accepted all of the recommendations, but that created too many errors to handle.I then filtered out only unused import errors. The proposed changes were mostly correct, but I had to do some manual fixes at the end to get CI to pass.
NOTE: At least in its current form, I don't think we want to merge this PR because it looks like
CLANGTIDY
has some false positives that do not result in CI checks failing. In particular, if we include headers X and Y, and Y also includes X, then even if we use a dependency specified in header X, it looks likeCLANGTIDY
still tries to get rid of theinclude
. In this case, we do not want to rely on a transitive inclusion.Test Plan
CI