Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #13223

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove unused imports #13223

wants to merge 2 commits into from

Conversation

archang19
Copy link
Contributor

@archang19 archang19 commented Dec 18, 2024

Summary

At first, I ran CLANGTIDY against the whole repo and accepted all of the recommendations, but that created too many errors to handle.

I then filtered out only unused import errors. The proposed changes were mostly correct, but I had to do some manual fixes at the end to get CI to pass.

NOTE: At least in its current form, I don't think we want to merge this PR because it looks like CLANGTIDY has some false positives that do not result in CI checks failing. In particular, if we include headers X and Y, and Y also includes X, then even if we use a dependency specified in header X, it looks like CLANGTIDY still tries to get rid of the include. In this case, we do not want to rely on a transitive inclusion.

Test Plan

CI

@archang19 archang19 changed the title Accept clang tidy suggestions Remove unused imports Dec 18, 2024
@archang19 archang19 force-pushed the arc-lint branch 2 times, most recently from f0280b4 to 0a17f7a Compare December 18, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants