Remove unused imports

cache/cache_bench_tool.cc

@@ -16,7 +16,6 @@
 #include "cache/sharded_cache.h"
 #include "db/db_impl/db_impl.h"
 #include "monitoring/histogram.h"
-#include "port/port.h"
 #include "port/stack_trace.h"
 #include "rocksdb/advanced_cache.h"
 #include "rocksdb/convenience.h"
@@ -26,8 +25,6 @@
 #include "rocksdb/system_clock.h"
 #include "rocksdb/table_properties.h"
 #include "table/block_based/block_based_table_reader.h"
-#include "table/block_based/cachable_entry.h"
-#include "util/coding.h"
 #include "util/distributed_mutex.h"
 #include "util/gflags_compat.h"
 #include "util/hash.h"

cache/cache_entry_roles.cc

@@ -7,7 +7,6 @@
 
 #include <mutex>
 
-#include "port/lang.h"
 
 namespace ROCKSDB_NAMESPACE {
 

cache/cache_reservation_manager.cc

@@ -10,14 +10,12 @@
 
 #include <cassert>
 #include <cstddef>
-#include <cstring>
 #include <memory>
 
 #include "rocksdb/cache.h"
 #include "rocksdb/slice.h"
 #include "rocksdb/status.h"
 #include "table/block_based/reader_common.h"
-#include "util/coding.h"
 
 namespace ROCKSDB_NAMESPACE {
 

cache/cache_reservation_manager_test.cc

@@ -12,11 +12,9 @@
 #include <cstring>
 #include <memory>
 
-#include "cache/cache_entry_roles.h"
 #include "rocksdb/cache.h"
 #include "rocksdb/slice.h"
 #include "test_util/testharness.h"
-#include "util/coding.h"
 
 namespace ROCKSDB_NAMESPACE {
 class CacheReservationManagerTest : public ::testing::Test {

cache/cache_test.cc

@@ -23,7 +23,6 @@
 #include "test_util/testharness.h"
 #include "util/coding.h"
 #include "util/hash_containers.h"
-#include "util/string_util.h"
 
 // HyperClockCache only supports 16-byte keys, so some of the tests
 // originally written for LRUCache do not work on the other caches.

cache/clock_cache.cc

@@ -27,8 +27,6 @@
 #include "cache/secondary_cache_adapter.h"
 #include "logging/logging.h"
 #include "monitoring/perf_context_imp.h"
-#include "monitoring/statistics_impl.h"
-#include "port/lang.h"
 #include "rocksdb/env.h"
 #include "util/hash.h"
 #include "util/math.h"

cache/compressed_secondary_cache.cc

@@ -13,7 +13,6 @@
 #include "monitoring/perf_context_imp.h"
 #include "util/coding.h"
 #include "util/compression.h"
-#include "util/string_util.h"
 
 namespace ROCKSDB_NAMESPACE {
 

cache/compressed_secondary_cache_test.cc

@@ -5,7 +5,6 @@
 
 #include "cache/compressed_secondary_cache.h"
 
-#include <array>
 #include <iterator>
 #include <memory>
 #include <tuple>

cache/lru_cache.cc

@@ -15,9 +15,6 @@
 #include <cstdlib>
 
 #include "cache/secondary_cache_adapter.h"
-#include "monitoring/perf_context_imp.h"
-#include "monitoring/statistics_impl.h"
-#include "port/lang.h"
 #include "util/distributed_mutex.h"
 
 namespace ROCKSDB_NAMESPACE {

cache/lru_cache_test.cc

@@ -13,8 +13,6 @@
 #include "cache/clock_cache.h"
 #include "cache_helpers.h"
 #include "db/db_test_util.h"
-#include "file/sst_file_manager_impl.h"
-#include "port/port.h"
 #include "port/stack_trace.h"
 #include "rocksdb/cache.h"
 #include "rocksdb/io_status.h"
@@ -23,7 +21,6 @@
 #include "test_util/secondary_cache_test_util.h"
 #include "test_util/testharness.h"
 #include "typed_cache.h"
-#include "util/coding.h"
 #include "util/random.h"
 #include "utilities/cache_dump_load_impl.h"
 #include "utilities/fault_injection_fs.h"

cache/secondary_cache.cc

@@ -5,7 +5,6 @@
 
 #include "rocksdb/secondary_cache.h"
 
-#include "cache/cache_entry_roles.h"
 
 namespace ROCKSDB_NAMESPACE {
 

db/arena_wrapped_db_iter.cc

@@ -14,8 +14,6 @@
 #include "rocksdb/iterator.h"
 #include "rocksdb/options.h"
 #include "table/internal_iterator.h"
-#include "table/iterator_wrapper.h"
-#include "util/user_comparator_wrapper.h"
 
 namespace ROCKSDB_NAMESPACE {
 

db/blob/blob_contents.cc

@@ -5,10 +5,8 @@
 
 #include "db/blob/blob_contents.h"
 
-#include <cassert>
 
 #include "cache/cache_entry_roles.h"
-#include "cache/cache_helpers.h"
 #include "port/malloc.h"
 
 namespace ROCKSDB_NAMESPACE {

db/blob/blob_file_builder.cc

@@ -14,14 +14,12 @@
 #include "db/blob/blob_log_format.h"
 #include "db/blob/blob_log_writer.h"
 #include "db/blob/blob_source.h"
-#include "db/event_helpers.h"
 #include "db/version_set.h"
 #include "file/filename.h"
 #include "file/read_write_util.h"
 #include "file/writable_file_writer.h"
 #include "logging/logging.h"
 #include "options/cf_options.h"
-#include "options/options_helper.h"
 #include "rocksdb/slice.h"
 #include "rocksdb/status.h"
 #include "test_util/sync_point.h"

db/blob/blob_file_builder_test.cc

@@ -6,7 +6,6 @@
 #include "db/blob/blob_file_builder.h"
 
 #include <cassert>
-#include <cinttypes>
 #include <string>
 #include <utility>
 #include <vector>
@@ -25,7 +24,6 @@
 #include "test_util/sync_point.h"
 #include "test_util/testharness.h"
 #include "util/compression.h"
-#include "utilities/fault_injection_env.h"
 
 namespace ROCKSDB_NAMESPACE {
 

db/blob/blob_file_reader.cc

@@ -20,7 +20,6 @@
 #include "table/multiget_context.h"
 #include "test_util/sync_point.h"
 #include "util/compression.h"
-#include "util/crc32c.h"
 #include "util/stop_watch.h"
 
 namespace ROCKSDB_NAMESPACE {

db/blob/blob_log_writer.cc

@@ -13,7 +13,6 @@
 #include "monitoring/statistics_impl.h"
 #include "rocksdb/system_clock.h"
 #include "test_util/sync_point.h"
-#include "util/coding.h"
 #include "util/stop_watch.h"
 
 namespace ROCKSDB_NAMESPACE {

db/blob/blob_source.cc

@@ -15,7 +15,6 @@
 #include "db/blob/blob_log_format.h"
 #include "monitoring/statistics_impl.h"
 #include "options/cf_options.h"
-#include "table/get_context.h"
 #include "table/multiget_context.h"
 
 namespace ROCKSDB_NAMESPACE {

db/blob/db_blob_index_test.cc

@@ -15,13 +15,10 @@
 #include "db/arena_wrapped_db_iter.h"
 #include "db/blob/blob_index.h"
 #include "db/column_family.h"
-#include "db/db_iter.h"
 #include "db/db_test_util.h"
 #include "db/dbformat.h"
 #include "db/write_batch_internal.h"
-#include "port/port.h"
 #include "port/stack_trace.h"
-#include "util/string_util.h"
 #include "utilities/merge_operators.h"
 
 namespace ROCKSDB_NAMESPACE {

db/builder.cc

@@ -29,11 +29,8 @@
 #include "file/writable_file_writer.h"
 #include "monitoring/iostats_context_imp.h"
 #include "monitoring/thread_status_util.h"
-#include "options/options_helper.h"
-#include "rocksdb/db.h"
 #include "rocksdb/env.h"
 #include "rocksdb/file_system.h"
-#include "rocksdb/iterator.h"
 #include "rocksdb/options.h"
 #include "rocksdb/table.h"
 #include "seqno_to_time_mapping.h"

db/c_test.c

@@ -10,11 +10,9 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <sys/types.h>
 #ifndef OS_WIN
 #include <unistd.h>
 #endif
-#include <inttypes.h>
 
 // Can not use port/port.h macros as this is a c file
 #ifdef OS_WIN

db/column_family.cc

@@ -31,9 +31,7 @@
 #include "db/write_controller.h"
 #include "file/sst_file_manager_impl.h"
 #include "logging/logging.h"
-#include "monitoring/thread_status_util.h"
 #include "options/options_helper.h"
-#include "port/port.h"
 #include "rocksdb/convenience.h"
 #include "rocksdb/table.h"
 #include "table/merging_iterator.h"

db/column_family_test.cc

@@ -16,14 +16,12 @@
 #include "db/db_impl/db_impl.h"
 #include "db/db_test_util.h"
 #include "options/options_parser.h"
-#include "port/port.h"
 #include "port/stack_trace.h"
 #include "rocksdb/comparator.h"
 #include "rocksdb/convenience.h"
 #include "rocksdb/db.h"
 #include "rocksdb/env.h"
 #include "rocksdb/iterator.h"
-#include "rocksdb/listener.h"
 #include "rocksdb/utilities/object_registry.h"
 #include "test_util/sync_point.h"
 #include "test_util/testharness.h"

db/compact_files_test.cc

@@ -10,13 +10,11 @@
 #include <vector>
 
 #include "db/db_impl/db_impl.h"
-#include "port/port.h"
 #include "rocksdb/db.h"
 #include "rocksdb/env.h"
 #include "test_util/sync_point.h"
 #include "test_util/testharness.h"
 #include "util/cast_util.h"
-#include "util/string_util.h"
 
 namespace ROCKSDB_NAMESPACE {
 

db/compaction/clipping_iterator_test.cc

@@ -10,7 +10,6 @@
 #include <string>
 #include <vector>
 
-#include "db/dbformat.h"
 #include "rocksdb/comparator.h"
 #include "test_util/testharness.h"
 #include "test_util/testutil.h"

db/compaction/compaction_iterator.cc

@@ -16,8 +16,6 @@
 #include "db/wide/wide_column_serialization.h"
 #include "db/wide/wide_columns_helper.h"
 #include "logging/logging.h"
-#include "port/likely.h"
-#include "rocksdb/listener.h"
 #include "table/internal_iterator.h"
 #include "test_util/sync_point.h"
 

db/compaction/compaction_iterator_test.cc

@@ -9,10 +9,8 @@
 #include <vector>
 
 #include "db/dbformat.h"
-#include "port/port.h"
 #include "test_util/testharness.h"
 #include "test_util/testutil.h"
-#include "util/string_util.h"
 #include "util/vector_iterator.h"
 #include "utilities/merge_operators.h"
 

db/compaction/compaction_job.cc

@@ -13,7 +13,6 @@
 #include <cinttypes>
 #include <memory>
 #include <optional>
-#include <set>
 #include <utility>
 #include <vector>
 
@@ -28,7 +27,6 @@
 #include "db/error_handler.h"
 #include "db/event_helpers.h"
 #include "db/history_trimming_iterator.h"
-#include "db/log_writer.h"
 #include "db/merge_helper.h"
 #include "db/range_del_aggregator.h"
 #include "db/version_edit.h"
@@ -41,17 +39,12 @@
 #include "logging/logging.h"
 #include "monitoring/iostats_context_imp.h"
 #include "monitoring/thread_status_util.h"
-#include "options/configurable_helper.h"
 #include "options/options_helper.h"
-#include "port/port.h"
-#include "rocksdb/db.h"
 #include "rocksdb/env.h"
 #include "rocksdb/options.h"
 #include "rocksdb/statistics.h"
 #include "rocksdb/status.h"
 #include "rocksdb/table.h"
-#include "rocksdb/utilities/options_type.h"
-#include "table/merging_iterator.h"
 #include "table/table_builder.h"
 #include "table/unique_id_impl.h"
 #include "test_util/sync_point.h"

db/compaction/compaction_job_stats_test.cc

@@ -12,20 +12,11 @@
 #include <iostream>
 #include <mutex>
 #include <queue>
-#include <set>
 #include <thread>
 #include <unordered_set>
 #include <utility>
 
 #include "db/db_impl/db_impl.h"
-#include "db/dbformat.h"
-#include "db/job_context.h"
-#include "db/version_set.h"
-#include "db/write_batch_internal.h"
-#include "env/mock_env.h"
-#include "file/filename.h"
-#include "monitoring/statistics_impl.h"
-#include "monitoring/thread_status_util.h"
 #include "port/stack_trace.h"
 #include "rocksdb/cache.h"
 #include "rocksdb/compaction_filter.h"
@@ -35,26 +26,17 @@
 #include "rocksdb/experimental.h"
 #include "rocksdb/filter_policy.h"
 #include "rocksdb/options.h"
-#include "rocksdb/perf_context.h"
 #include "rocksdb/slice.h"
 #include "rocksdb/slice_transform.h"
 #include "rocksdb/table.h"
 #include "rocksdb/table_properties.h"
-#include "rocksdb/thread_status.h"
-#include "rocksdb/utilities/checkpoint.h"
-#include "rocksdb/utilities/write_batch_with_index.h"
-#include "table/block_based/block_based_table_factory.h"
 #include "table/mock_table.h"
-#include "table/plain/plain_table_factory.h"
 #include "test_util/sync_point.h"
 #include "test_util/testharness.h"
 #include "test_util/testutil.h"
 #include "util/cast_util.h"
 #include "util/compression.h"
-#include "util/hash.h"
-#include "util/mutexlock.h"
 #include "util/rate_limiter_impl.h"
-#include "util/string_util.h"
 #include "utilities/merge_operators.h"
 
 #if !defined(IOS_CROSS_COMPILE)

db/compaction/compaction_job_test.cc

@@ -8,7 +8,6 @@
 
 #include <algorithm>
 #include <array>
-#include <cinttypes>
 #include <map>
 #include <string>
 #include <tuple>
@@ -31,7 +30,6 @@
 #include "table/unique_id_impl.h"
 #include "test_util/testharness.h"
 #include "test_util/testutil.h"
-#include "util/string_util.h"
 #include "utilities/merge_operators.h"
 
 namespace ROCKSDB_NAMESPACE {