Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export YGInteropSetLogger method #960

Closed
wants to merge 3 commits into from
Closed

Export YGInteropSetLogger method #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a29a3a
Export YGInteropSetLogger method
KimDaeWook Jan 11, 2020
da107f8
Update Yoga.cpp
KimDaeWook Jan 11, 2020
4c0de5f
Update Yoga.h
KimDaeWook Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csharp/Yoga/YGInterop.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ static int unmanagedLogger(const YGConfigRef config,
return result;
}

void YGInteropSetLogger(YGInteropLogger managedLogger) {
YOGA_EXPORT void YGInteropSetLogger(YGInteropLogger managedLogger) {
gManagedLogger = managedLogger;
YGConfigSetLogger(YGConfigGetDefault(), &unmanagedLogger);
}
5 changes: 5 additions & 0 deletions yoga/Yoga.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4363,6 +4363,11 @@ YOGA_EXPORT void YGConfigSetUseWebDefaults(
config->useWebDefaults = enabled;
}

YOGA_EXPORT bool YGConfigGetUseLegacyStretchBehaviour(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need this ? This flag might be removed in future.

const YGConfigRef config) {
return config->useLegacyStretchBehaviour;
}

YOGA_EXPORT void YGConfigSetUseLegacyStretchBehaviour(
const YGConfigRef config,
const bool useLegacyStretchBehaviour) {
Expand Down
1 change: 1 addition & 0 deletions yoga/Yoga.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ void YGConfigSetShouldDiffLayoutWithoutLegacyStretchBehaviour(
// resulted in implicit behaviour similar to align-self: stretch; Because this
// was such a long-standing bug we must allow legacy users to switch back to
// this behaviour.
WIN_EXPORT bool YGConfigGetUseLegacyStretchBehaviour(YGConfigRef config);
WIN_EXPORT void YGConfigSetUseLegacyStretchBehaviour(
YGConfigRef config,
bool useLegacyStretchBehaviour);
Expand Down