Export YGInteropSetLogger method #960
Conversation
|
Hi KimDaeWook! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
And YGConfigGetUseLegacyStretchBehaviour is not defined, so i add it additionally. |
| @@ -4363,6 +4363,11 @@ YOGA_EXPORT void YGConfigSetUseWebDefaults( | |||
| config->useWebDefaults = enabled; | |||
| } | |||
|
|
|||
| YOGA_EXPORT bool YGConfigGetUseLegacyStretchBehaviour( | |||
There was a problem hiding this comment.
Do you really need this ? This flag might be removed in future.
|
Thanks for creating this PR. |
|
It looks like the C# bindings already assume Otherwise, fixing the mismatch in export declaration is a good change. |
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: When building and using C # libraries, EntryPointNotFoundException thrown from YGInteropSetLogger. so, I added YOGA_EXPORT on YGInteropSetLogger. X-link: facebook/yoga#960 Reviewed By: yungsters Differential Revision: D40027238 Pulled By: yungsters fbshipit-source-id: 6af584a16e66a31c91374a1bb64434888762e3c8
Summary: When building and using C # libraries, EntryPointNotFoundException thrown from YGInteropSetLogger. so, I added YOGA_EXPORT on YGInteropSetLogger. X-link: facebook/yoga#960 Reviewed By: yungsters Differential Revision: D40027238 Pulled By: yungsters fbshipit-source-id: 6af584a16e66a31c91374a1bb64434888762e3c8
Summary: When building and using C # libraries, EntryPointNotFoundException thrown from YGInteropSetLogger. so, I added YOGA_EXPORT on YGInteropSetLogger. X-link: facebook/yoga#960 Reviewed By: yungsters Differential Revision: D40027238 Pulled By: yungsters fbshipit-source-id: 6af584a16e66a31c91374a1bb64434888762e3c8
When building and using C # libraries,
EntryPointNotFoundException thrown from YGInteropSetLogger.
so, I added YOGA_EXPORT on YGInteropSetLogger.