migrated website to docusaurus 2 #47
Conversation
|
Hi ozgunbal! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
website/package.json
Outdated
| "devDependencies": { | ||
| "docusaurus": "^1.0.9" | ||
| "dependencies": { | ||
| "@docusaurus/core": "^2.0.0-alpha.26", |
There was a problem hiding this comment.
We've just published .27, could you upgrade to that?
website/docusaurus.config.js
Outdated
| links: [ | ||
| { to: "docs/getting-started", label: "Docs", position: "left" }, | ||
| { | ||
| href: "https://github.com/facebook/docusaurus", |
There was a problem hiding this comment.
done. live version is updated, too.
website/src/pages/index.js
Outdated
| {features.map(({ title, description }, idx) => ( | ||
| <div | ||
| key={idx} | ||
| className={classnames("col col--6", styles.feature)} |
There was a problem hiding this comment.
Class feature does not exist.
| className={classnames("col col--6", styles.feature)} | |
| className="col col--6" |
website/src/pages/index.js
Outdated
| <Link | ||
| className={classnames( | ||
| "button button--secondary button--lg", | ||
| styles.getStarted |
website/src/pages/index.js
Outdated
| <div className="container"> | ||
| <h1 className="hero__title">{siteConfig.title}</h1> | ||
| <p className="hero__subtitle">{siteConfig.tagline}</p> | ||
| <p className="lead"> |
There was a problem hiding this comment.
| <p className="lead"> | |
| <p> |
|
Hey, thanks so much for taking care of this migration. One quick thing, though. Any chance we can make the font of all the code snippets a big bigger? It's kind of hard to read right now :( |
There was a problem hiding this comment.
@ricardorey10 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I pulled the PR but just noticed that it explicitly says that it should not be landed. I'll wait for the final version. |
|
I agree regarding the font size. But maybe we could handle it at the Docusaurus level. This issue is not specific to Profilo. Thanks for reviewing @ricardorey10! |
|
hi, i assume font-size would be handled via docusaurus , right @yangshun ? @ricardorey10 other than that, I can't see details of failed |
|
@BurntBrunch merged this pull request in 5d07114. |
Summary: Depends on facebookincubator/fbjni#43. Removes all Bintray-specifics and replaces it with a Maven Central setup. Docs for this are coming next. Pull Request resolved: facebookincubator/fbjni#47 Test Plan: ``` ./gradlew uploadArchives ./gradlew -b host.gradle uploadArchives ``` Worked! Won't publish this, obviously.  Reviewed By: priteshrnandgaonkar Differential Revision: D26546096 Pulled By: passy fbshipit-source-id: cb74a5cb3caed1cbf9d7bd07125fd2fcb28e3d85
Summary: - Live version: https://build.ozgunbal.now.sh/ - I only removed github star counts below `Get Started` button at v1:  It can be added if it's necessary but IMHO, doesn't look good with new theme. - Hey, yangshun and endiliey . You can check it when you're available. - This PR related to facebookarchive/profilo#46 and facebook/docusaurus#1834 Pull Request resolved: facebookarchive/profilo#47 Differential Revision: D18064160 Pulled By: BurntBrunch fbshipit-source-id: 70b67a519455f3072246373661966e0bd6f84c36
Get Startedbutton at v1:It can be added if it's necessary but IMHO, doesn't look good with new theme.