Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prefab #43

Closed
wants to merge 2 commits into from
Closed

Enable prefab #43

wants to merge 2 commits into from

Conversation

passy
Copy link
Member

@passy passy commented Feb 18, 2021

Summary:

This enables the long-awaited "prefab" mode which is a proper binary and header distribution for pre-built binaries. More on that here: https://google.github.io/prefab/.

This will likely break backwards-compatibility with packages not using prefab, so we will want to at least bump the minor version for the next release.

Test Plan:

./gradlew assemble

unzip -l build/outputs/aar/fbjni-release.aar shows we've got headers (well, actually all source) plus binaries in a prefab/ folder.

Checked that this builds with Flipper by publishing it locally.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2021
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy has updated the pull request. You must reimport the pull request before landing.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in 87e261c.

facebook-github-bot pushed a commit to facebookarchive/profilo that referenced this pull request Feb 21, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Summary:
This enables the long-awaited "prefab" mode which is a proper binary and header distribution for pre-built binaries. More on that here: https://google.github.io/prefab/.

This will likely break backwards-compatibility with packages not using prefab, so we will want to at least bump the minor version for the next release. In case that this causes too much trouble, we can publish a separate non-prefab distribution, but we will tackle that reactively.

Pull Request resolved: facebookincubator/fbjni#43

Test Plan:
./gradlew assemble

`unzip -l build/outputs/aar/fbjni-release.aar` shows we've got headers (well, actually all source) plus binaries in a `prefab/` folder.

Checked that this builds with Flipper by publishing it locally and depending on it. PR for this will follow.

Reviewed By: fabiomassimo

Differential Revision: D26517673

Pulled By: passy

fbshipit-source-id: a05087f98df2116793ec37b1ffeb358684ae1dfe
facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Feb 21, 2021
Summary:
This enables the long-awaited "prefab" mode which is a proper binary and header distribution for pre-built binaries. More on that here: https://google.github.io/prefab/.

This will likely break backwards-compatibility with packages not using prefab, so we will want to at least bump the minor version for the next release. In case that this causes too much trouble, we can publish a separate non-prefab distribution, but we will tackle that reactively.

Pull Request resolved: facebookincubator/fbjni#43

Test Plan:
./gradlew assemble

`unzip -l build/outputs/aar/fbjni-release.aar` shows we've got headers (well, actually all source) plus binaries in a `prefab/` folder.

Checked that this builds with Flipper by publishing it locally and depending on it. PR for this will follow.

Reviewed By: fabiomassimo

Differential Revision: D26517673

Pulled By: passy

fbshipit-source-id: a05087f98df2116793ec37b1ffeb358684ae1dfe
facebook-github-bot pushed a commit that referenced this pull request Feb 22, 2021
Summary:
Depends on #43.
Removes all Bintray-specifics and replaces it with a Maven Central setup. Docs for this are coming next.

Pull Request resolved: #47

Test Plan:
```
./gradlew uploadArchives
./gradlew -b host.gradle uploadArchives
```

Worked! Won't publish this, obviously.

![Screenshot 2021-02-19 at 16 15 22](https://user-images.githubusercontent.com/9906/108531010-1d93ff80-72ce-11eb-800f-b61035184ef0.png)

Reviewed By: priteshrnandgaonkar

Differential Revision: D26546096

Pulled By: passy

fbshipit-source-id: cb74a5cb3caed1cbf9d7bd07125fd2fcb28e3d85
facebook-github-bot pushed a commit to facebookarchive/profilo that referenced this pull request Feb 22, 2021
Summary:
Depends on facebookincubator/fbjni#43.
Removes all Bintray-specifics and replaces it with a Maven Central setup. Docs for this are coming next.

Pull Request resolved: facebookincubator/fbjni#47

Test Plan:
```
./gradlew uploadArchives
./gradlew -b host.gradle uploadArchives
```

Worked! Won't publish this, obviously.

![Screenshot 2021-02-19 at 16 15 22](https://user-images.githubusercontent.com/9906/108531010-1d93ff80-72ce-11eb-800f-b61035184ef0.png)

Reviewed By: priteshrnandgaonkar

Differential Revision: D26546096

Pulled By: passy

fbshipit-source-id: cb74a5cb3caed1cbf9d7bd07125fd2fcb28e3d85
facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Feb 22, 2021
Summary:
Depends on facebookincubator/fbjni#43.
Removes all Bintray-specifics and replaces it with a Maven Central setup. Docs for this are coming next.

Pull Request resolved: facebookincubator/fbjni#47

Test Plan:
```
./gradlew uploadArchives
./gradlew -b host.gradle uploadArchives
```

Worked! Won't publish this, obviously.

![Screenshot 2021-02-19 at 16 15 22](https://user-images.githubusercontent.com/9906/108531010-1d93ff80-72ce-11eb-800f-b61035184ef0.png)

Reviewed By: priteshrnandgaonkar

Differential Revision: D26546096

Pulled By: passy

fbshipit-source-id: cb74a5cb3caed1cbf9d7bd07125fd2fcb28e3d85
EduardoCostaom pushed a commit to EduardoCostaom/profilo that referenced this pull request Nov 2, 2022
Summary:
This enables the long-awaited "prefab" mode which is a proper binary and header distribution for pre-built binaries. More on that here: https://google.github.io/prefab/.

This will likely break backwards-compatibility with packages not using prefab, so we will want to at least bump the minor version for the next release. In case that this causes too much trouble, we can publish a separate non-prefab distribution, but we will tackle that reactively.

Pull Request resolved: facebookincubator/fbjni#43

Test Plan:
./gradlew assemble

`unzip -l build/outputs/aar/fbjni-release.aar` shows we've got headers (well, actually all source) plus binaries in a `prefab/` folder.

Checked that this builds with Flipper by publishing it locally and depending on it. PR for this will follow.

Reviewed By: fabiomassimo

Differential Revision: D26517673

Pulled By: passy

fbshipit-source-id: a05087f98df2116793ec37b1ffeb358684ae1dfe
EduardoCostaom pushed a commit to EduardoCostaom/profilo that referenced this pull request Nov 2, 2022
Summary:
Depends on facebookincubator/fbjni#43.
Removes all Bintray-specifics and replaces it with a Maven Central setup. Docs for this are coming next.

Pull Request resolved: facebookincubator/fbjni#47

Test Plan:
```
./gradlew uploadArchives
./gradlew -b host.gradle uploadArchives
```

Worked! Won't publish this, obviously.

![Screenshot 2021-02-19 at 16 15 22](https://user-images.githubusercontent.com/9906/108531010-1d93ff80-72ce-11eb-800f-b61035184ef0.png)

Reviewed By: priteshrnandgaonkar

Differential Revision: D26546096

Pulled By: passy

fbshipit-source-id: cb74a5cb3caed1cbf9d7bd07125fd2fcb28e3d85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants