-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable prefab #43
Enable prefab #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@passy has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: This enables the long-awaited "prefab" mode which is a proper binary and header distribution for pre-built binaries. More on that here: https://google.github.io/prefab/. This will likely break backwards-compatibility with packages not using prefab, so we will want to at least bump the minor version for the next release. In case that this causes too much trouble, we can publish a separate non-prefab distribution, but we will tackle that reactively. Pull Request resolved: facebookincubator/fbjni#43 Test Plan: ./gradlew assemble `unzip -l build/outputs/aar/fbjni-release.aar` shows we've got headers (well, actually all source) plus binaries in a `prefab/` folder. Checked that this builds with Flipper by publishing it locally and depending on it. PR for this will follow. Reviewed By: fabiomassimo Differential Revision: D26517673 Pulled By: passy fbshipit-source-id: a05087f98df2116793ec37b1ffeb358684ae1dfe
Summary: This enables the long-awaited "prefab" mode which is a proper binary and header distribution for pre-built binaries. More on that here: https://google.github.io/prefab/. This will likely break backwards-compatibility with packages not using prefab, so we will want to at least bump the minor version for the next release. In case that this causes too much trouble, we can publish a separate non-prefab distribution, but we will tackle that reactively. Pull Request resolved: facebookincubator/fbjni#43 Test Plan: ./gradlew assemble `unzip -l build/outputs/aar/fbjni-release.aar` shows we've got headers (well, actually all source) plus binaries in a `prefab/` folder. Checked that this builds with Flipper by publishing it locally and depending on it. PR for this will follow. Reviewed By: fabiomassimo Differential Revision: D26517673 Pulled By: passy fbshipit-source-id: a05087f98df2116793ec37b1ffeb358684ae1dfe
Summary: Depends on #43. Removes all Bintray-specifics and replaces it with a Maven Central setup. Docs for this are coming next. Pull Request resolved: #47 Test Plan: ``` ./gradlew uploadArchives ./gradlew -b host.gradle uploadArchives ``` Worked! Won't publish this, obviously.  Reviewed By: priteshrnandgaonkar Differential Revision: D26546096 Pulled By: passy fbshipit-source-id: cb74a5cb3caed1cbf9d7bd07125fd2fcb28e3d85
Summary: Depends on facebookincubator/fbjni#43. Removes all Bintray-specifics and replaces it with a Maven Central setup. Docs for this are coming next. Pull Request resolved: facebookincubator/fbjni#47 Test Plan: ``` ./gradlew uploadArchives ./gradlew -b host.gradle uploadArchives ``` Worked! Won't publish this, obviously.  Reviewed By: priteshrnandgaonkar Differential Revision: D26546096 Pulled By: passy fbshipit-source-id: cb74a5cb3caed1cbf9d7bd07125fd2fcb28e3d85
Summary: Depends on facebookincubator/fbjni#43. Removes all Bintray-specifics and replaces it with a Maven Central setup. Docs for this are coming next. Pull Request resolved: facebookincubator/fbjni#47 Test Plan: ``` ./gradlew uploadArchives ./gradlew -b host.gradle uploadArchives ``` Worked! Won't publish this, obviously.  Reviewed By: priteshrnandgaonkar Differential Revision: D26546096 Pulled By: passy fbshipit-source-id: cb74a5cb3caed1cbf9d7bd07125fd2fcb28e3d85
Summary: This enables the long-awaited "prefab" mode which is a proper binary and header distribution for pre-built binaries. More on that here: https://google.github.io/prefab/. This will likely break backwards-compatibility with packages not using prefab, so we will want to at least bump the minor version for the next release. In case that this causes too much trouble, we can publish a separate non-prefab distribution, but we will tackle that reactively. Pull Request resolved: facebookincubator/fbjni#43 Test Plan: ./gradlew assemble `unzip -l build/outputs/aar/fbjni-release.aar` shows we've got headers (well, actually all source) plus binaries in a `prefab/` folder. Checked that this builds with Flipper by publishing it locally and depending on it. PR for this will follow. Reviewed By: fabiomassimo Differential Revision: D26517673 Pulled By: passy fbshipit-source-id: a05087f98df2116793ec37b1ffeb358684ae1dfe
Summary: Depends on facebookincubator/fbjni#43. Removes all Bintray-specifics and replaces it with a Maven Central setup. Docs for this are coming next. Pull Request resolved: facebookincubator/fbjni#47 Test Plan: ``` ./gradlew uploadArchives ./gradlew -b host.gradle uploadArchives ``` Worked! Won't publish this, obviously.  Reviewed By: priteshrnandgaonkar Differential Revision: D26546096 Pulled By: passy fbshipit-source-id: cb74a5cb3caed1cbf9d7bd07125fd2fcb28e3d85
Summary:
This enables the long-awaited "prefab" mode which is a proper binary and header distribution for pre-built binaries. More on that here: https://google.github.io/prefab/.
This will likely break backwards-compatibility with packages not using prefab, so we will want to at least bump the minor version for the next release.
Test Plan:
./gradlew assemble
unzip -l build/outputs/aar/fbjni-release.aar
shows we've got headers (well, actually all source) plus binaries in aprefab/
folder.Checked that this builds with Flipper by publishing it locally.