getInfo() always reports atom/selector type. (#1547)

Summary:
Pull Request resolved: #1547

When `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()` callbacks were originally implemented the atom and selector internal node interface was more abstract.  Now there is an explicit `'atom' | 'selector'` type which we can use to always report the type of any registered node.

Reviewed By: habond

Differential Revision: D33559658

fbshipit-source-id: 096b04f0211e58604c949c61d51d2b0257f05e87

CHANGELOG.md

@@ -43,6 +43,7 @@
 
 ### Breaking Changes
 - Atom effect initialization takes precedence over initialization with `<RecoilRoot initializeState={...} >`. (#1509)
+- `useGetRecoilValueInfo_UNSTABLE()` and `Snapshot#getInfo_UNSTABLE()` always report the node `type`. (#1547)
 
 ## 0.5.2 (2021-11-07)
 

packages/recoil/core/Recoil_FunctionalCore.js

@@ -179,7 +179,7 @@ export type RecoilValueInfo<T> = {
  isActive: boolean,
  isSet: boolean,
  isModified: boolean, // TODO report modified selectors
- type: 'atom' | 'selector' | void, // void until initialized for now
+ type: 'atom' | 'selector',
  deps: Iterable<RecoilValue<mixed>>,
  subscribers: {
  nodes: Iterable<RecoilValue<mixed>>,
@@ -194,11 +194,7 @@ function peekNodeInfo<T>(
 ): RecoilValueInfo<T> {
  const storeState = store.getState();
  const graph = store.getGraph(state.version);
- const type = storeState.knownAtoms.has(key)
- ? 'atom'
- : storeState.knownSelectors.has(key)
- ? 'selector'
- : undefined;
+ const type = getNode(key).nodeType;
  const downstreamNodes = filterIterable(
  getDownstreamNodes(store, state, new Set([key])),
  nodeKey => nodeKey !== key,

packages/recoil/core/__tests__/Recoil_Snapshot-test.js

@@ -359,7 +359,7 @@ testRecoil('getInfo', () => {
  isActive: false,
  isSet: false,
  isModified: false,
- type: undefined,
+ type: 'atom',
  });
  expect(Array.from(snapshot.getInfo_UNSTABLE(myAtom).deps)).toEqual([]);
  expect(
@@ -370,7 +370,7 @@ testRecoil('getInfo', () => {
  isActive: false,
  isSet: false,
  isModified: false,
- type: undefined,
+ type: 'selector',
  });
  expect(Array.from(snapshot.getInfo_UNSTABLE(selectorA).deps)).toEqual([]);
  expect(
@@ -381,7 +381,7 @@ testRecoil('getInfo', () => {
  isActive: false,
  isSet: false,
  isModified: false,
- type: undefined,
+ type: 'selector',
  });
  expect(Array.from(snapshot.getInfo_UNSTABLE(selectorB).deps)).toEqual([]);
  expect(

packages/recoil/hooks/__tests__/Recoil_useGetRecoilValueInfo-test.js

@@ -73,7 +73,7 @@ testRecoil(
  isActive: false,
  isSet: false,
  isModified: false,
- type: undefined,
+ type: 'atom',
  });
  expect(Array.from(getRecoilValueInfo(myAtom).deps)).toEqual([]);
  expect(Array.from(getRecoilValueInfo(myAtom).subscribers.nodes)).toEqual(
@@ -89,7 +89,7 @@ testRecoil(
  isActive: false,
  isSet: false,
  isModified: false,
- type: undefined,
+ type: 'selector',
  });
  expect(Array.from(getRecoilValueInfo(selectorA).deps)).toEqual([]);
  expect(Array.from(getRecoilValueInfo(selectorA).subscribers.nodes)).toEqual(
@@ -105,7 +105,7 @@ testRecoil(
  isActive: false,
  isSet: false,
  isModified: false,
- type: undefined,
+ type: 'selector',
  });
  expect(Array.from(getRecoilValueInfo(selectorB).deps)).toEqual([]);
  expect(Array.from(getRecoilValueInfo(selectorB).subscribers.nodes)).toEqual(

typescript/index.d.ts

@@ -52,7 +52,7 @@
  isActive: boolean;
  isSet: boolean;
  isModified: boolean; // TODO report modified selectors
- type: 'atom' | 'selector' | undefined; // undefined until initialized for now
+ type: 'atom' | 'selector';
  deps: Iterable<RecoilValue<T>>;
  subscribers: {
  nodes: Iterable<RecoilValue<T>>,