This repository has been archived by the owner on Jan 1, 2025. It is now read-only.
getNodeInfo() always reports atom/selector type. #1547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33559658 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D33559658 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Jan 13, 2022
Summary: Pull Request resolved: facebookexperimental#1547 When `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()` callbacks were originally implemented the atom and selector internal node interface was more abstract. Now there is an explicit `'atom' | 'selector'` type which we can use to always report the type of any registered node. Differential Revision: D33559658 fbshipit-source-id: b7e86fb9d7c500867a86b370bf9eb8c591765c89
drarmstr
force-pushed
the
export-D33559658
branch
from
a55821b to
9c16309
Compare
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Jan 13, 2022
Summary: Pull Request resolved: facebookexperimental#1547 When `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()` callbacks were originally implemented the atom and selector internal node interface was more abstract. Now there is an explicit `'atom' | 'selector'` type which we can use to always report the type of any registered node. Differential Revision: https://www.internalfb.com/diff/D33559658?entry_point=27 fbshipit-source-id: 640d00e65afa23850e4a9e1486b996efe0390247
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Jan 13, 2022
Summary: Pull Request resolved: facebookexperimental#1547 When `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()` callbacks were originally implemented the atom and selector internal node interface was more abstract. Now there is an explicit `'atom' | 'selector'` type which we can use to always report the type of any registered node. Differential Revision: https://www.internalfb.com/diff/D33559658?entry_point=27 fbshipit-source-id: 269ff67675aaffa87c009f7535a781b1f54c85e9
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Jan 13, 2022
Summary: Pull Request resolved: facebookexperimental#1547 When `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()` callbacks were originally implemented the atom and selector internal node interface was more abstract. Now there is an explicit `'atom' | 'selector'` type which we can use to always report the type of any registered node. Differential Revision: https://www.internalfb.com/diff/D33559658?entry_point=27 fbshipit-source-id: 039ef1b4404992a18372de4111d178e201660b52
|
This pull request was exported from Phabricator. Differential Revision: D33559658 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Jan 19, 2022
Summary: Pull Request resolved: facebookexperimental#1547 When `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()` callbacks were originally implemented the atom and selector internal node interface was more abstract. Now there is an explicit `'atom' | 'selector'` type which we can use to always report the type of any registered node. Reviewed By: habond Differential Revision: D33559658 fbshipit-source-id: 4b056de83c39b2cc31b058ebef407f6163b95a5a
drarmstr
force-pushed
the
export-D33559658
branch
from
9c16309 to
aa2b185
Compare
Summary: Suppress the uninitialized store lint warning for Snapshot when it is initialized in the constructor. Differential Revision: D33494577 fbshipit-source-id: 55b19a108ca6a847168a116381f59f946c35bcc4
Summary: Retain snapshot for an async selector test. Differential Revision: D33491312 fbshipit-source-id: 3a44e404c76226065efe7f9d92ae45d7eb85e045
Summary: `versionsUsedByComponent` was added in D22450204 (facebookexperimental@856c561) but never used, so remove it. Differential Revision: https://www.internalfb.com/diff/D33494634?entry_point=27 fbshipit-source-id: 844de5d4f56ec639ada4900f6c250dd458908a7e
Summary: Cleanup legacy oncalls in file headers to `recoil` Differential Revision: D33494708 fbshipit-source-id: 465dc3966c68f6c85232cdbc982d4852bf5e4cdd
Summary: Stub performance tests for Recoil. These are intended to be manual tests for now, so only run a single iteration for automated testing. Differential Revision: D33522344 fbshipit-source-id: 3911b0d70efd00f644f2c5dd64a62a94c7bc181c
Summary: Pull Request resolved: facebookexperimental#1547 When `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()` callbacks were originally implemented the atom and selector internal node interface was more abstract. Now there is an explicit `'atom' | 'selector'` type which we can use to always report the type of any registered node. Reviewed By: habond Differential Revision: D33559658 fbshipit-source-id: 0704ef35e58a91ca56e434bc56ba0f6e12b6f0db
drarmstr
force-pushed
the
export-D33559658
branch
from
aa2b185 to
ca0a797
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33559658 |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#1547 When `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()` callbacks were originally implemented the atom and selector internal node interface was more abstract. Now there is an explicit `'atom' | 'selector'` type which we can use to always report the type of any registered node. Reviewed By: habond Differential Revision: D33559658 fbshipit-source-id: 096b04f0211e58604c949c61d51d2b0257f05e87
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1547 When `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()` callbacks were originally implemented the atom and selector internal node interface was more abstract. Now there is an explicit `'atom' | 'selector'` type which we can use to always report the type of any registered node. Reviewed By: habond Differential Revision: D33559658 fbshipit-source-id: 096b04f0211e58604c949c61d51d2b0257f05e87
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1547 When `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()` callbacks were originally implemented the atom and selector internal node interface was more abstract. Now there is an explicit `'atom' | 'selector'` type which we can use to always report the type of any registered node. Reviewed By: habond Differential Revision: D33559658 fbshipit-source-id: 096b04f0211e58604c949c61d51d2b0257f05e87
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When
getNodeInfo_UNSTABLE()was originally implemented the atom and selector internal node interface was more abstract. Now there is an explicit'atom' | 'selector'type which we can use to always report the type of any registered node.Differential Revision: D33559658